Re: pg_basebackup is taking backup of extra files inside a tablespace directory - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: pg_basebackup is taking backup of extra files inside a tablespace directory
Date
Msg-id CABUevEwqQK+uiMGFbKV90soUT2JBJrZQpDyEqqKd=wQncx5i=Q@mail.gmail.com
Whole thread Raw
In response to Re: pg_basebackup is taking backup of extra files inside a tablespace directory  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, Nov 30, 2012 at 8:30 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, Nov 28, 2012 at 1:55 AM, Hari Babu <haribabu.kommi@huawei.com> wrote:
>> I think backup should be done only files and folders present inside
>> '/opt/tblspc/PG_*' directory (TABLESPACE_VERSION_DIRECTORY).
>> Not all the files and folders in side '/opt/tblspc.' directory.
>
> I think I agree.  The current behavior would have made sense in older
> releases of PG where we plopped down our stuff right inside the
> tablespace directory, but now that everything is being shoved in a
> subdirectory I don't see a reason to copy anything other than that
> subdirectory.  Of course it's probably bad style to have anything
> that's not related to PG in there, but given that the whole point of
> this change was to allow different PG versions to create tablespaces
> on the same directory at the same time, we can hardly say that this is
> a case that should never arise in real life.

Makes sense, yeah. Of course, anything stuffed *inside* said subdir
will still be included, but that's violating that principle even more
:)

--Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/



pgsql-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Re: Proof of concept: auto updatable views [Review of Patch]
Next
From: Fujii Masao
Date:
Subject: Re: [BUG?] lag of minRecoveryPont in archive recovery