Thread: review: psql tab completion for GRANT role
Hello I did review of this small patch http://archives.postgresql.org/message-id/1326055692.15293.15.camel@vanquo.pezone.net * This patch was applied without with one hunk and compiled without warnings bash-4.2$ patch -p1 < autocompleta.patch patching file src/bin/psql/tab-complete.c Hunk #2 succeeded at 2335 with fuzz 1. * all regress tests was processed * this patch respect Pg coding standards * code is simple and has not impact on core functionality or core performance * regress tests are not requested for interactive function * I checked it, and autocomplete has expected behave. It is ready for commit Regards Pavel Stehule
On tis, 2012-01-17 at 13:03 +0100, Pavel Stehule wrote: > Hello > > I did review of this small patch > http://archives.postgresql.org/message-id/1326055692.15293.15.camel@vanquo.pezone.net > > * This patch was applied without with one hunk and compiled without warnings > > bash-4.2$ patch -p1 < autocompleta.patch > patching file src/bin/psql/tab-complete.c > Hunk #2 succeeded at 2335 with fuzz 1. > > * all regress tests was processed > > * this patch respect Pg coding standards > * code is simple and has not impact on core functionality or core performance > * regress tests are not requested for interactive function > * I checked it, and autocomplete has expected behave. > > It is ready for commit Committed, thanks.