review: psql tab completion for GRANT role - Mailing list pgsql-hackers

From Pavel Stehule
Subject review: psql tab completion for GRANT role
Date
Msg-id CAFj8pRA+OzQ5ghE9Z2FJ5knYMb1JJiFjY-L1k-4WUmMSJrtAKw@mail.gmail.com
Whole thread Raw
Responses Re: review: psql tab completion for GRANT role  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Hello

I did review of this small patch
http://archives.postgresql.org/message-id/1326055692.15293.15.camel@vanquo.pezone.net

* This patch was applied without with one hunk and compiled without warnings

bash-4.2$ patch -p1 < autocompleta.patch
patching file src/bin/psql/tab-complete.c
Hunk #2 succeeded at 2335 with fuzz 1.

* all regress tests was processed

* this patch respect Pg coding standards
* code is simple and has not impact on core functionality or core performance
* regress tests are not requested for interactive function
* I checked it, and autocomplete has expected behave.

It is ready for commit

Regards

Pavel Stehule


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: BGWriter latch, power saving
Next
From: Susanne Ebrecht
Date:
Subject: Re: 9.3 feature proposal: vacuumdb -j #