Thread: Re: [COMMITTERS] pgsql: remove tags.

Re: [COMMITTERS] pgsql: remove tags.

From
Tom Lane
Date:
Bruce Momjian <bruce@momjian.us> writes:
> Bruce Momjian wrote:
>> remove tags.

> Sorry, vague commit message (I forgot squash).

> Can I will use git ammend to improve this message?

How about git revert, instead?  It's not apparent to me that these
changes were improvements.

            regards, tom lane

Re: [COMMITTERS] pgsql: remove tags.

From
Robert Haas
Date:
On Sun, Feb 6, 2011 at 11:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Bruce Momjian <bruce@momjian.us> writes:
>> Bruce Momjian wrote:
>>> remove tags.
>
>> Sorry, vague commit message (I forgot squash).
>
>> Can I will use git ammend to improve this message?

Absolutely not.

> How about git revert, instead?  It's not apparent to me that these
> changes were improvements.

I'll buy that one.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [COMMITTERS] pgsql: remove tags.

From
Bruce Momjian
Date:
Robert Haas wrote:
> On Sun, Feb 6, 2011 at 11:12 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> >> Bruce Momjian wrote:
> >>> remove tags.
> >
> >> Sorry, vague commit message (I forgot squash).
> >
> >> Can I will use git ammend to improve this message?
>
> Absolutely not.
>
> > How about git revert, instead? ?It's not apparent to me that these
> > changes were improvements.
>
> I'll buy that one.

[  CC to docs, committers removed. ]

Well, if we want to revert, then we have to add <literal> to all the
numbers used in our docs --- there was no logic in what we previously
had.  Do we want that?

Here is an example line I did not change:

   an otherwise idle connection.  A value of 0 uses the system default.

Do we want that 0 to appear in a fixed-width font via <literal>?
It is easy to do but we should decide.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +