Thread: Typo in plperl doc ?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey, While translating the plperl page from the manual, I found the following sentence: The <varname>%_SHARED</varname> variable and other global state within the language is public data. Should it be : The <varname>%_SHARED</varname> variable and other global variables within the language are public data. ? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkwV3tYACgkQxWGfaAgowiJPFQCfaROauKGDLu0ODZXCbshb9dVe AfYAnAx+PvopgycLm7KPHdd6l8202vOm =Ky/1 -----END PGP SIGNATURE-----
On Mon, Jun 14, 2010 at 3:48 AM, Jehan-Guillaume (ioguix) de Rorthais <ioguix@free.fr> wrote: > While translating the plperl page from the manual, I found the following > sentence: > > The <varname>%_SHARED</varname> variable and other global state within > the language is public data. > > Should it be : > > The <varname>%_SHARED</varname> variable and other global variables > within the language are public data. > > ? "State" is a more general term, which would include any information that is globally accessible from within the interpreter, not just what's stored in variables. Off the top of my head, I'm not sure if there is anything like that, but I wouldn't bet on there not being any... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 14/06/2010 14:08, Robert Haas wrote: > On Mon, Jun 14, 2010 at 3:48 AM, Jehan-Guillaume (ioguix) de Rorthais > <ioguix@free.fr> wrote: >> While translating the plperl page from the manual, I found the following >> sentence: >> >> The <varname>%_SHARED</varname> variable and other global state within >> the language is public data. >> >> Should it be : >> >> The <varname>%_SHARED</varname> variable and other global variables >> within the language are public data. >> >> ? > > "State" is a more general term, which would include any information > that is globally accessible from within the interpreter, not just > what's stored in variables. Off the top of my head, I'm not sure if > there is anything like that, but I wouldn't bet on there not being > any... Ok, so shouldn't it be "The <varname>%_SHARED</varname> variable and other global state(s?) within the language *are* public data" ? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkwWOhsACgkQxWGfaAgowiK1WwCfQbFGVIRW4PbJwdrV7fjRL8wt PiEAn3/NuXSGm5CjHtGzHREnl5DB+LBa =4IEb -----END PGP SIGNATURE-----
On Mon, Jun 14, 2010 at 10:18 AM, Jehan-Guillaume (ioguix) de Rorthais <ioguix@free.fr> wrote: > On 14/06/2010 14:08, Robert Haas wrote: >> On Mon, Jun 14, 2010 at 3:48 AM, Jehan-Guillaume (ioguix) de Rorthais >> <ioguix@free.fr> wrote: >>> While translating the plperl page from the manual, I found the following >>> sentence: >>> >>> The <varname>%_SHARED</varname> variable and other global state within >>> the language is public data. >>> >>> Should it be : >>> >>> The <varname>%_SHARED</varname> variable and other global variables >>> within the language are public data. >>> >>> ? >> >> "State" is a more general term, which would include any information >> that is globally accessible from within the interpreter, not just >> what's stored in variables. Off the top of my head, I'm not sure if >> there is anything like that, but I wouldn't bet on there not being >> any... > > Ok, so shouldn't it be > > "The <varname>%_SHARED</varname> variable and other global state(s?) > within the language *are* public data" > > ? It seems correct to me as-is, but I just work here. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company
-----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 ... > what's stored in variables. Off the top of my head, I'm not sure if > there is anything like that, but I wouldn't bet on there not being > any... I'm with Robert: I don't see much of a problem here. I might even suggest removing the references to non %_SHARED globals entirely. If there is something else that is implicitly shared, I'd like to know what it is. Tim B? Andrew D? - -- Greg Sabino Mullane greg@turnstep.com End Point Corporation http://www.endpoint.com/ PGP Key: 0x14964AC8 201006141055 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -----BEGIN PGP SIGNATURE----- iEYEAREDAAYFAkwWQuQACgkQvJuQZxSWSsif6QCg0Vsfml3rn5nrIFUXF2oFCWka kPYAoONxmYh8YVUNJnoI8Mtd292PKFUD =YoqE -----END PGP SIGNATURE-----
Robert Haas wrote: >> Ok, so shouldn't it be >> >> "The <varname>%_SHARED</varname> variable and other global state(s?) >> within the language *are* public data" >> >> ? >> > > It seems correct to me as-is, but I just work here. > Umm, you don't say "Joe and Mary is people." (Or I hope you don't.) So "are" looks correct here to me. If the subject of the verb is plural then the verb should be in the plural form. cheers andrew
On Mon, Jun 14, 2010 at 10:59 AM, Andrew Dunstan <andrew@dunslane.net> wrote: > Robert Haas wrote: >>> Ok, so shouldn't it be >>> >>> "The <varname>%_SHARED</varname> variable and other global state(s?) >>> within the language *are* public data" >>> >>> ? >> It seems correct to me as-is, but I just work here. > > Umm, you don't say "Joe and Mary is people." (Or I hope you don't.) So "are" > looks correct here to me. If the subject of the verb is plural then the verb > should be in the plural form. Yeah, you might be right. I won't attempt to explain why I thought this case might be different from that one... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company
Robert Haas wrote: > On Mon, Jun 14, 2010 at 10:59 AM, Andrew Dunstan <andrew@dunslane.net> wrote: > > Robert Haas wrote: > >>> Ok, so shouldn't it be > >>> > >>> "The <varname>%_SHARED</varname> variable and other global state(s?) > >>> within the language *are* public data" > >>> > >>> ? > >> It seems correct to me as-is, but I just work here. > > > > Umm, you don't say "Joe and Mary is people." (Or I hope you don't.) So "are" > > looks correct here to me. If the subject of the verb is plural then the verb > > should be in the plural form. > > Yeah, you might be right. I won't attempt to explain why I thought > this case might be different from that one... Agreed, attached patch applied. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + None of us is going to be here forever. + Index: plperl.sgml =================================================================== RCS file: /cvsroot/pgsql/doc/src/sgml/plperl.sgml,v retrieving revision 2.84 retrieving revision 2.85 diff -c -c -r2.84 -r2.85 *** plperl.sgml 13 May 2010 16:39:43 -0000 2.84 --- plperl.sgml 14 Jun 2010 18:47:05 -0000 2.85 *************** *** 835,841 **** <para> The <varname>%_SHARED</varname> variable and other global state within ! the language is public data, available to all PL/Perl functions within a session. Use with care, especially in situations that involve use of multiple roles or <literal>SECURITY DEFINER</> functions. </para> --- 835,841 ---- <para> The <varname>%_SHARED</varname> variable and other global state within ! the language are public data, available to all PL/Perl functions within a session. Use with care, especially in situations that involve use of multiple roles or <literal>SECURITY DEFINER</> functions. </para>