Thread: bug in build_startup_packet()

bug in build_startup_packet()

From
Fujii Masao
Date:
Hi,

We seem to have forgotten to give conn->replication "[0]".

diff --git a/src/interfaces/libpq/fe-protocol3.c
b/src/interfaces/libpq/fe-protocol3.c
index 77cee8a..1956f00 100644
--- a/src/interfaces/libpq/fe-protocol3.c
+++ b/src/interfaces/libpq/fe-protocol3.c
@@ -1909,7 +1909,7 @@ build_startup_packet(const PGconn *conn, char *packet,               ADD_STARTUP_OPTION("user",
conn->pguser);      if (conn->dbName && conn->dbName[0])               ADD_STARTUP_OPTION("database", conn->dbName);
 
-       if (conn->replication && conn->replication)
+       if (conn->replication && conn->replication[0])               ADD_STARTUP_OPTION("replication",
conn->replication);      if (conn->pgoptions && conn->pgoptions[0])               ADD_STARTUP_OPTION("options",
conn->pgoptions);

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


Re: bug in build_startup_packet()

From
Magnus Hagander
Date:
On Wed, Apr 28, 2010 at 14:43, Fujii Masao <masao.fujii@gmail.com> wrote:
> Hi,
>
> We seem to have forgotten to give conn->replication "[0]".

Oops.

Applied, thanks.


-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/