bug in build_startup_packet() - Mailing list pgsql-hackers

From Fujii Masao
Subject bug in build_startup_packet()
Date
Msg-id k2h3f0b79eb1004280543h6535fc26z9f294c02f97462c1@mail.gmail.com
Whole thread Raw
Responses Re: bug in build_startup_packet()  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Hi,

We seem to have forgotten to give conn->replication "[0]".

diff --git a/src/interfaces/libpq/fe-protocol3.c
b/src/interfaces/libpq/fe-protocol3.c
index 77cee8a..1956f00 100644
--- a/src/interfaces/libpq/fe-protocol3.c
+++ b/src/interfaces/libpq/fe-protocol3.c
@@ -1909,7 +1909,7 @@ build_startup_packet(const PGconn *conn, char *packet,               ADD_STARTUP_OPTION("user",
conn->pguser);      if (conn->dbName && conn->dbName[0])               ADD_STARTUP_OPTION("database", conn->dbName);
 
-       if (conn->replication && conn->replication)
+       if (conn->replication && conn->replication[0])               ADD_STARTUP_OPTION("replication",
conn->replication);      if (conn->pgoptions && conn->pgoptions[0])               ADD_STARTUP_OPTION("options",
conn->pgoptions);

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Add column if not exists (CINE)
Next
From: Simon Riggs
Date:
Subject: Re: testing HS/SR - 1 vs 2 performance