Thread: Fast or immediate shutdown

Fast or immediate shutdown

From
Simon Riggs
Date:
running with log_checkpoints = on

pg_ctl -D foo -m fast stop

log says

LOG:  received fast shutdown request
LOG:  aborting any active transactions
LOG:  shutting down
LOG:  restartpoint starting: shutdown immediate

Some of us know that the "immediate" word refers to the restartpoint
request, though that word causes conceptual conflict with the shutdown
mode, which was fast, not immediate.

Think we need to change the wording of this

LOG:  restartpoint starting: shutdown immediate

so it is clearer what we mean

-- Simon Riggs           www.2ndQuadrant.com



Re: Fast or immediate shutdown

From
Robert Haas
Date:
On Tue, Dec 15, 2009 at 12:19 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> running with log_checkpoints = on
>
> pg_ctl -D foo -m fast stop
>
> log says
>
> LOG:  received fast shutdown request
> LOG:  aborting any active transactions
> LOG:  shutting down
> LOG:  restartpoint starting: shutdown immediate
>
> Some of us know that the "immediate" word refers to the restartpoint
> request, though that word causes conceptual conflict with the shutdown
> mode, which was fast, not immediate.
>
> Think we need to change the wording of this
>
> LOG:  restartpoint starting: shutdown immediate
>
> so it is clearer what we mean

We could insert the words "with flags" just before the colon, I suppose.

...Robert


Re: Fast or immediate shutdown

From
Peter Eisentraut
Date:
On tis, 2009-12-15 at 17:19 +0000, Simon Riggs wrote:
> running with log_checkpoints = on
> 
> pg_ctl -D foo -m fast stop
> 
> log says
> 
> LOG:  received fast shutdown request
> LOG:  aborting any active transactions
> LOG:  shutting down
> LOG:  restartpoint starting: shutdown immediate
> 
> Some of us know that the "immediate" word refers to the restartpoint
> request, though that word causes conceptual conflict with the shutdown
> mode, which was fast, not immediate.
> 
> Think we need to change the wording of this
> 
> LOG:  restartpoint starting: shutdown immediate
> 
> so it is clearer what we mean

We *do* we mean?  And why are we logging it?



Re: Fast or immediate shutdown

From
Simon Riggs
Date:
On Wed, 2009-12-16 at 17:04 +0200, Peter Eisentraut wrote:
> On tis, 2009-12-15 at 17:19 +0000, Simon Riggs wrote:
> > running with log_checkpoints = on
> > 
> > pg_ctl -D foo -m fast stop
> > 
> > log says
> > 
> > LOG:  received fast shutdown request
> > LOG:  aborting any active transactions
> > LOG:  shutting down
> > LOG:  restartpoint starting: shutdown immediate
> > 
> > Some of us know that the "immediate" word refers to the restartpoint
> > request, though that word causes conceptual conflict with the shutdown
> > mode, which was fast, not immediate.
> > 
> > Think we need to change the wording of this
> > 
> > LOG:  restartpoint starting: shutdown immediate
> > 
> > so it is clearer what we mean
> 
> We *do* we mean?  And why are we logging it?

The words after the colon refer to options sent to RequestCheckpoint and
it is logged because we asked for it by doing log_checkpoints = on.

I suggest we say "smoothed" when checkpoint option is !immediate. So we
will remove the word "immediate" from the message.

-- Simon Riggs           www.2ndQuadrant.com



Re: Fast or immediate shutdown

From
Peter Eisentraut
Date:
On ons, 2009-12-16 at 15:42 +0000, Simon Riggs wrote:
> I suggest we say "smoothed" when checkpoint option is !immediate. So
> we
> will remove the word "immediate" from the message. 

The opposite of smooth could be sharp. :)



Re: Fast or immediate shutdown

From
Bruce Momjian
Date:
Simon Riggs wrote:
> On Wed, 2009-12-16 at 17:04 +0200, Peter Eisentraut wrote:
> > On tis, 2009-12-15 at 17:19 +0000, Simon Riggs wrote:
> > > running with log_checkpoints = on
> > > 
> > > pg_ctl -D foo -m fast stop
> > > 
> > > log says
> > > 
> > > LOG:  received fast shutdown request
> > > LOG:  aborting any active transactions
> > > LOG:  shutting down
> > > LOG:  restartpoint starting: shutdown immediate
> > > 
> > > Some of us know that the "immediate" word refers to the restartpoint
> > > request, though that word causes conceptual conflict with the shutdown
> > > mode, which was fast, not immediate.
> > > 
> > > Think we need to change the wording of this
> > > 
> > > LOG:  restartpoint starting: shutdown immediate
> > > 
> > > so it is clearer what we mean
> > 
> > We *do* we mean?  And why are we logging it?
> 
> The words after the colon refer to options sent to RequestCheckpoint and
> it is logged because we asked for it by doing log_checkpoints = on.
> 
> I suggest we say "smoothed" when checkpoint option is !immediate. So we
> will remove the word "immediate" from the message.

Did we decide not the change this?

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


Re: Fast or immediate shutdown

From
Robert Haas
Date:
On Fri, Feb 19, 2010 at 2:48 PM, Bruce Momjian <bruce@momjian.us> wrote:
> Simon Riggs wrote:
>> On Wed, 2009-12-16 at 17:04 +0200, Peter Eisentraut wrote:
>> > On tis, 2009-12-15 at 17:19 +0000, Simon Riggs wrote:
>> > > running with log_checkpoints = on
>> > >
>> > > pg_ctl -D foo -m fast stop
>> > >
>> > > log says
>> > >
>> > > LOG:  received fast shutdown request
>> > > LOG:  aborting any active transactions
>> > > LOG:  shutting down
>> > > LOG:  restartpoint starting: shutdown immediate
>> > >
>> > > Some of us know that the "immediate" word refers to the restartpoint
>> > > request, though that word causes conceptual conflict with the shutdown
>> > > mode, which was fast, not immediate.
>> > >
>> > > Think we need to change the wording of this
>> > >
>> > > LOG:  restartpoint starting: shutdown immediate
>> > >
>> > > so it is clearer what we mean
>> >
>> > We *do* we mean?  And why are we logging it?
>>
>> The words after the colon refer to options sent to RequestCheckpoint and
>> it is logged because we asked for it by doing log_checkpoints = on.
>>
>> I suggest we say "smoothed" when checkpoint option is !immediate. So we
>> will remove the word "immediate" from the message.
>
> Did we decide not the change this?

Personally, my opinion is that if we're going to print the message at
all, the names used for the message should match the names used in the
code.  So -1 from me on calling it immediate in the code but smoothed
in the message.  On the other hand, I have no personal attachment to
that message, so if other people feel it's not needed at all, I could
see removing it.

...Robert