Thread: [PATCH] Add solaris path for docbook COLLATEINDEX
collateindex.pl is stored in /usr/share/sgml/docbook/. Attached fix
modify docbook.m4 to find correct path.
It would be nice also backported the fix back at least to 8.2.
Thanks Zdenek
Attachment
Zdenek Kotala wrote:
> collateindex.pl is stored in /usr/share/sgml/docbook/. Attached fix
> modify docbook.m4 to find correct path.
>
> It would be nice also backported the fix back at least to 8.2.
I am not happy looking in a directory _above_ a specified directory by
default:
[$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH])
That seems possibly unsafe. I suggest you just add it to the PATH for
Solaris builds.
-- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB
http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500: > Zdenek Kotala wrote: > > collateindex.pl is stored in /usr/share/sgml/docbook/. Attached fix > > modify docbook.m4 to find correct path. > > > > It would be nice also backported the fix back at least to 8.2. > > I am not happy looking in a directory _above_ a specified directory by > default: > > [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH]) > > That seems possibly unsafe. I suggest you just add it to the PATH for > Solaris builds. I'm not sure if it is unsafer that searching in $PATH. Anyway I don't think that your proposed solution is good way. I'm able to do it but how many other people can? Who know where collateindex.pl stays on Solaris? configure is here to make live easier for people. If we know how to do it automatically we should do it. If you think that $DOCBOOKSTYLE/.. is not good than I propose to use /usr/share/sgml/docbook/ directly. Zdenek
On mån, 2009-11-30 at 19:53 +0100, Zdenek Kotala wrote: > Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500: > > I am not happy looking in a directory _above_ a specified directory by > > default: > > > > [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH]) > > > > That seems possibly unsafe. I suggest you just add it to the PATH for > > Solaris builds. > > I'm not sure if it is unsafer that searching in $PATH. Anyway I don't > think that your proposed solution is good way. I'm able to do it but how > many other people can? Who know where collateindex.pl stays on Solaris? > configure is here to make live easier for people. If we know how to do > it automatically we should do it. Note that $DOCBOOKSTYLE/bin corresponds to the location of the file in an unpacked source archive and $PATH is of course where programs normally go. The $DOCBOOKSTYLE/.. location makes no sense at all, because that basically says that the installer intentionally moved the file, but to a completely nonstandard location. > If you think that $DOCBOOKSTYLE/.. is not good than I propose to > use /usr/share/sgml/docbook/ directly. That would be the less ugly solution.
Peter Eisentraut píše v po 30. 11. 2009 v 21:27 +0200:
> On mån, 2009-11-30 at 19:53 +0100, Zdenek Kotala wrote:
> > Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500:
> > > I am not happy looking in a directory _above_ a specified directory by
> > > default:
> > >
> > > [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH])
> > >
> > > That seems possibly unsafe. I suggest you just add it to the PATH for
> > > Solaris builds.
> >
> > I'm not sure if it is unsafer that searching in $PATH. Anyway I don't
> > think that your proposed solution is good way. I'm able to do it but how
> > many other people can? Who know where collateindex.pl stays on Solaris?
> > configure is here to make live easier for people. If we know how to do
> > it automatically we should do it.
>
> Note that $DOCBOOKSTYLE/bin corresponds to the location of the file in
> an unpacked source archive and $PATH is of course where programs
> normally go. The $DOCBOOKSTYLE/.. location makes no sense at all,
> because that basically says that the installer intentionally moved the
> file, but to a completely nonstandard location.
I'm not sgml//docbook guru. Do you think that Solaris location of
collateindex.pl is wrong? Does exist any recommendation for this? I
could log a bug, but I need some link with recommendation.
> > If you think that $DOCBOOKSTYLE/.. is not good than I propose to
> > use /usr/share/sgml/docbook/ directly.
>
> That would be the less ugly solution.
Patch attached.
thanks Zdenek
Attachment
On mån, 2009-11-30 at 20:57 +0100, Zdenek Kotala wrote: > I'm not sgml//docbook guru. Do you think that Solaris location of > collateindex.pl is wrong? Does exist any recommendation for this? I > could log a bug, but I need some link with recommendation. It's a normal program, so you install it where you would normally install programs. Like /usr/bin/ or something similar.