Re: [PATCH] Add solaris path for docbook COLLATEINDEX - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Add solaris path for docbook COLLATEINDEX
Date
Msg-id 1259609257.24894.2.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: [PATCH] Add solaris path for docbook COLLATEINDEX  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
Responses Re: [PATCH] Add solaris path for docbook COLLATEINDEX
List pgsql-hackers
On mån, 2009-11-30 at 19:53 +0100, Zdenek Kotala wrote:
> Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500:
> > I am not happy looking in a directory _above_ a specified directory by
> > default:
> > 
> >                  [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH])
> > 
> > That seems possibly unsafe.  I suggest you just add it to the PATH for
> > Solaris builds.
> 
> I'm not sure if it is unsafer that searching in $PATH. Anyway I don't
> think that your proposed solution is good way. I'm able to do it but how
> many other people can? Who know where collateindex.pl stays on Solaris?
> configure is here to make live easier for people. If we know how to do
> it automatically we should do it.

Note that $DOCBOOKSTYLE/bin corresponds to the location of the file in
an unpacked source archive and $PATH is of course where programs
normally go.  The $DOCBOOKSTYLE/.. location makes no sense at all,
because that basically says that the installer intentionally moved the
file, but to a completely nonstandard location.

> If you think that $DOCBOOKSTYLE/.. is not good than I propose to
> use /usr/share/sgml/docbook/ directly.

That would be the less ugly solution.




pgsql-hackers by date:

Previous
From: Marko Tiikkaja
Date:
Subject: Re: Writeable CTE patch
Next
From: "Kevin Grittner"
Date:
Subject: Re: Deleted WAL files held open by backends in Linux