Thread: Re: change do_tup_output to take Datum arguments rather than cstring

On Mon, Jun 15, 2009 at 1:20 PM, Tom Lane<tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> it looks like I can probably rip that member out of TupOutputState
>> altogether.
>
>> Will update patch.  Does this look like what you were thinking otherwise?
>
> Yeah, that's exactly what I was thinking.

Excellent.  Revised patch attached.

...Robert

Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Jun 15, 2009 at 1:20 PM, Tom Lane<tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> it looks like I can probably rip that member out of TupOutputState
>>> altogether.
>> 
>> Yeah, that's exactly what I was thinking.

> Excellent.  Revised patch attached.

Applied with minor editorialization.

It strikes me that it would now be quite easy to make the
efficiency improvement alluded to in do_tup_output's comment:
* XXX This could be made more efficient, since in reality we probably only* need a virtual tuple.

but I didn't have time to investigate that right now (got to leave for
a dentist appointment :-()
        regards, tom lane