Thread: cs_CZ vs regression tests, part N
It's still broken: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01 I remain of the opinion that supporting the regression tests in a locale that works like this is more trouble than it's worth. regards, tom lane
Dne 18.03.09 13:35, Tom Lane napsal(a): > It's still broken: > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01 Yes, it is. But it is PL test now ;-). > I remain of the opinion that supporting the regression tests in a locale > that works like this is more trouble than it's worth. Problem disappear when collation per column will be implemented. Until it we need to workaround it somehow. Zdenek
Tom Lane wrote: > It's still broken: > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01 > > I remain of the opinion that supporting the regression tests in a locale > that works like this is more trouble than it's worth. We looked into this and it turns out that this is actually a C locale vs. all-other-locales issue; not specific to Czech. More specifically, it is related to the sorting of upper-case vs. lower-case letters. A _1.out file is an appropriate answer here. (Hmm, no one except Zdenek testing locales yet on the build farm? Can't easily tell from the index page.)
Peter Eisentraut wrote: > Tom Lane wrote: >> It's still broken: >> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01 >> >> >> I remain of the opinion that supporting the regression tests in a locale >> that works like this is more trouble than it's worth. > > We looked into this and it turns out that this is actually a C locale > vs. all-other-locales issue; not specific to Czech. More > specifically, it is related to the sorting of upper-case vs. > lower-case letters. A _1.out file is an appropriate answer here. > > (Hmm, no one except Zdenek testing locales yet on the build farm? > Can't easily tell from the index page.) > Yes, dungbeetle is ... I took tcl out of its config until we had this sorted out. Are you going to commit a _1.out file? cheers andrew
Peter Eisentraut píše v pá 20. 03. 2009 v 15:33 +0200: > (Hmm, no one except Zdenek testing locales yet on the build farm? Can't > easily tell from the index page.) It seems to me like good idea to add column with locale list tested on a animal. Zdenek
Andrew Dunstan wrote: > Yes, dungbeetle is ... I took tcl out of its config until we had this > sorted out. Are you going to commit a _1.out file? Done
Peter Eisentraut wrote: > Andrew Dunstan wrote: >> Yes, dungbeetle is ... I took tcl out of its config until we had this >> sorted out. Are you going to commit a _1.out file? > > Done Can't catch a break: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01 This time it's the btree_gist and tsearch tests that are complaining, and this time it is because of the Czech locale rules.
Dne 24.03.09 08:43, Peter Eisentraut napsal(a): > Peter Eisentraut wrote: >> Andrew Dunstan wrote: >>> Yes, dungbeetle is ... I took tcl out of its config until we had this >>> sorted out. Are you going to commit a _1.out file? >> >> Done > > Can't catch a break: > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01 > > > This time it's the btree_gist and tsearch tests that are complaining, > and this time it is because of the Czech locale rules. Patch attached. I hope last one. thanks Zdenek
Attachment
Please, can somebody look on this patch? I would like to have green lights on my buildfarms. thanks Zdenek Dne 24.03.09 12:23, Zdenek Kotala napsal(a): > Dne 24.03.09 08:43, Peter Eisentraut napsal(a): >> Peter Eisentraut wrote: >>> Andrew Dunstan wrote: >>>> Yes, dungbeetle is ... I took tcl out of its config until we had >>>> this sorted out. Are you going to commit a _1.out file? >>> >>> Done >> >> Can't catch a break: >> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01 >> >> >> This time it's the btree_gist and tsearch tests that are complaining, >> and this time it is because of the Czech locale rules. > > Patch attached. I hope last one. > > thanks Zdenek > > > ------------------------------------------------------------------------ > >
This diff in tsearch2.out surprised me: @@ -2390,7 +2390,7 @@ <body> <b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i> <a href="http://www.google.com/foo.bar.html"target="_blank">YES </a> - ff-bg + ff-bg <script> document.write(15); </script> Any idea what's causing that? Zdenek Kotala wrote: > Please, can somebody look on this patch? I would like to have green > lights on my buildfarms. > > thanks Zdenek > > > > Dne 24.03.09 12:23, Zdenek Kotala napsal(a): >> Dne 24.03.09 08:43, Peter Eisentraut napsal(a): >>> Peter Eisentraut wrote: >>>> Andrew Dunstan wrote: >>>>> Yes, dungbeetle is ... I took tcl out of its config until we had >>>>> this sorted out. Are you going to commit a _1.out file? >>>> >>>> Done >>> >>> Can't catch a break: >>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01 >>> >>> >>> This time it's the btree_gist and tsearch tests that are complaining, >>> and this time it is because of the Czech locale rules. >> >> Patch attached. I hope last one. >> >> thanks Zdenek >> >> >> ------------------------------------------------------------------------ >> >> > > -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
Dne 24.04.09 07:17, Heikki Linnakangas napsal(a): > This diff in tsearch2.out surprised me: > > @@ -2390,7 +2390,7 @@ > <body> > <b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i> > <a href="http://www.google.com/foo.bar.html" target="_blank">YES > </a> > - ff-bg > + ff-bg > <script> > document.write(15); > </script> > > Any idea what's causing that? Good catch. I don't see it on http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=comet_moth&dt=2009-04-24%2004:47:44 I'm playing with it now. Unfortunately I don't have my laptop with workspace now. Thanks Zdenek > > > Zdenek Kotala wrote: >> Please, can somebody look on this patch? I would like to have green >> lights on my buildfarms. >> >> thanks Zdenek >> >> >> >> Dne 24.03.09 12:23, Zdenek Kotala napsal(a): >>> Dne 24.03.09 08:43, Peter Eisentraut napsal(a): >>>> Peter Eisentraut wrote: >>>>> Andrew Dunstan wrote: >>>>>> Yes, dungbeetle is ... I took tcl out of its config until we had >>>>>> this sorted out. Are you going to commit a _1.out file? >>>>> >>>>> Done >>>> >>>> Can't catch a break: >>>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01 >>>> >>>> >>>> This time it's the btree_gist and tsearch tests that are >>>> complaining, and this time it is because of the Czech locale rules. >>> >>> Patch attached. I hope last one. >>> >>> thanks Zdenek >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >> >> > >
Dne 24.04.09 07:17, Heikki Linnakangas napsal(a): > This diff in tsearch2.out surprised me: > > @@ -2390,7 +2390,7 @@ > <body> > <b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i> > <a href="http://www.google.com/foo.bar.html" target="_blank">YES > </a> > - ff-bg > + ff-bg > <script> > document.write(15); > </script> > > Any idea what's causing that? Hmm. I don't understand it. I'm not able to generate this again nad I don't have idea why it happend. It is definitely wrong. Shell I sent you new diff or do you fix it yourself? Thanks Zdenek
Zdenek Kotala wrote: > Dne 24.04.09 07:17, Heikki Linnakangas napsal(a): >> This diff in tsearch2.out surprised me: >> >> @@ -2390,7 +2390,7 @@ >> <body> >> <b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i> >> <a href="http://www.google.com/foo.bar.html" target="_blank">YES >> </a> >> - ff-bg >> + ff-bg >> <script> >> document.write(15); >> </script> >> >> Any idea what's causing that? > > Hmm. I don't understand it. I'm not able to generate this again nad I > don't have idea why it happend. It is definitely wrong. Shell I sent you > new diff or do you fix it yourself? Committed, without that mystery change. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com