Thread: New pg_dump patch -- document statistics collector exception
This is a proposed patch to document disabling the statistics collector
pg_dump activity, and give a bit more visibility to the PGOPTIONS
environment variable supported by libpq.
It is an alternative to the prior patch, which supplied a --no-stats flag.
This is a documentation only patch, not tied to a recent code change.
? HTML.index
? test.man
Index: ref/pg_dump.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/pg_dump.sgml,v
retrieving revision 1.106
diff -c -2 -r1.106 pg_dump.sgml
*** ref/pg_dump.sgml 5 Jan 2009 16:54:36 -0000 1.106
--- ref/pg_dump.sgml 21 Jan 2009 01:15:41 -0000
***************
*** 727,733 ****
<term><envar>PGDATABASE</envar></term>
<term><envar>PGHOST</envar></term>
<term><envar>PGPORT</envar></term>
- <term><envar>PGUSER</envar></term>
<listitem>
<para>
--- 727,734 ----
<term><envar>PGDATABASE</envar></term>
<term><envar>PGHOST</envar></term>
+ <term><envar>PGOPTIONS</envar></term>
<term><envar>PGPORT</envar></term>
+ <term><envar>PGUSER</envar></term>
<listitem>
<para>
***************
*** 735,738 ****
--- 736,740 ----
</para>
</listitem>
+
</varlistentry>
</variablelist>
***************
*** 758,761 ****
--- 760,770 ----
library will apply.
</para>
+ <para>
+ The database activity of <application>pg_dump</application> is normally collected by the statistics collector.
+ If this is undesirable, you can set parameters <literal>stats_block_level</literal> and
<literal>stats_row_level</literal>to false
+ via the <application>libpq</> <envar>PGOPTIONS</envar> environment varriable, or via <literal>ALTER
USER</literal>.
+ </para>
+
+
</refsect1>
Index: ref/pg_dumpall.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/pg_dumpall.sgml,v
retrieving revision 1.74
diff -c -2 -r1.74 pg_dumpall.sgml
*** ref/pg_dumpall.sgml 5 Jan 2009 16:54:36 -0000 1.74
--- ref/pg_dumpall.sgml 21 Jan 2009 01:15:41 -0000
***************
*** 446,449 ****
--- 446,450 ----
<varlistentry>
<term><envar>PGHOST</envar></term>
+ <term><envar>PGOPTIONS</envar></term>
<term><envar>PGPORT</envar></term>
<term><envar>PGUSER</envar></term>
Index: ref/pg_restore.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/pg_restore.sgml,v
retrieving revision 1.77
diff -c -2 -r1.77 pg_restore.sgml
*** ref/pg_restore.sgml 5 Jan 2009 16:54:36 -0000 1.77
--- ref/pg_restore.sgml 21 Jan 2009 01:15:41 -0000
***************
*** 538,541 ****
--- 538,542 ----
<varlistentry>
<term><envar>PGHOST</envar></term>
+ <term><envar>PGOPTIONS</envar></term>
<term><envar>PGPORT</envar></term>
<term><envar>PGUSER</envar></term>
On Tuesday 20 January 2009 20:22:10 Bryce Nesbitt wrote: > This is a proposed patch to document disabling the statistics collector > pg_dump activity, and give a bit more visibility to the PGOPTIONS > environment variable supported by libpq. > > It is an alternative to the prior patch, which supplied a --no-stats flag. > > This is a documentation only patch, not tied to a recent code change. s/varriable/variable/g also, I forget which way is proper, but you're inconsistent with your closing tags for <application> in that paragraph (using both </application and </>) -- Robert Treat Conjecture: http://www.xzilla.net Consulting: http://www.omniti.com
Robert Treat wrote: > also, I forget which way is proper, but you're inconsistent with your closing > tags for <application> in that paragraph (using both </application and </>) They're both acceptable. -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)
From
Bryce Nesbitt
Date:
Here's a revision (thanks Robert Treat for the spelling corrextion).
If there are no other objections, how do I nominate it for consideration?
-Bryce
Index: pg_dump.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/pg_dump.sgml,v
retrieving revision 1.106
diff -c -2 -r1.106 pg_dump.sgml
*** pg_dump.sgml 5 Jan 2009 16:54:36 -0000 1.106
--- pg_dump.sgml 23 Jan 2009 20:57:36 -0000
***************
*** 727,733 ****
<term><envar>PGDATABASE</envar></term>
<term><envar>PGHOST</envar></term>
<term><envar>PGPORT</envar></term>
- <term><envar>PGUSER</envar></term>
<listitem>
<para>
--- 727,734 ----
<term><envar>PGDATABASE</envar></term>
<term><envar>PGHOST</envar></term>
+ <term><envar>PGOPTIONS</envar></term>
<term><envar>PGPORT</envar></term>
+ <term><envar>PGUSER</envar></term>
<listitem>
<para>
***************
*** 735,738 ****
--- 736,740 ----
</para>
</listitem>
+
</varlistentry>
</variablelist>
***************
*** 758,761 ****
--- 760,772 ----
library will apply.
</para>
+ <para>
+ The database activity of <application>pg_dump</application> is normally collected by the
+ statistics collector. If this is undesirable, you can set parameters
+ <literal>stats_block_level</literal> and <literal>stats_row_level</literal> to false
+ via the <application>libpq</application> <envar>PGOPTIONS</envar> environment variable,
+ or via <literal>ALTER USER</literal>.
+ </para>
+
+
</refsect1>
Index: pg_dumpall.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/pg_dumpall.sgml,v
retrieving revision 1.74
diff -c -2 -r1.74 pg_dumpall.sgml
*** pg_dumpall.sgml 5 Jan 2009 16:54:36 -0000 1.74
--- pg_dumpall.sgml 23 Jan 2009 20:57:36 -0000
***************
*** 446,449 ****
--- 446,450 ----
<varlistentry>
<term><envar>PGHOST</envar></term>
+ <term><envar>PGOPTIONS</envar></term>
<term><envar>PGPORT</envar></term>
<term><envar>PGUSER</envar></term>
Index: pg_restore.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/pg_restore.sgml,v
retrieving revision 1.77
diff -c -2 -r1.77 pg_restore.sgml
*** pg_restore.sgml 5 Jan 2009 16:54:36 -0000 1.77
--- pg_restore.sgml 23 Jan 2009 20:57:36 -0000
***************
*** 538,541 ****
--- 538,542 ----
<varlistentry>
<term><envar>PGHOST</envar></term>
+ <term><envar>PGOPTIONS</envar></term>
<term><envar>PGPORT</envar></term>
<term><envar>PGUSER</envar></term>
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)
From
Josh Berkus
Date:
Bryce Nesbitt wrote: > Here's a revision (thanks Robert Treat for the spelling corrextion). > If there are no other objections, how do I nominate it for consideration? > -Bryce You already have. Mind you, in the future when you're not continuing a discussion from a code patch, you should submit doc patches to pgsql-docs. But I'm sure Peter has seen it here. --Josh
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)
From
Euler Taveira de Oliveira
Date:
Bryce Nesbitt escreveu: > Here's a revision (thanks Robert Treat for the spelling corrextion). > If there are no other objections, how do I nominate it for consideration? > Added to next commit fest [1]. [1] http://wiki.postgresql.org/wiki/CommitFest_2009-First -- Euler Taveira de Oliveira http://www.timbira.com/
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)
From
Josh Berkus
Date:
Euler Taveira de Oliveira wrote: > Bryce Nesbitt escreveu: >> Here's a revision (thanks Robert Treat for the spelling corrextion). >> If there are no other objections, how do I nominate it for consideration? >> > Added to next commit fest [1]. Um, not necessary. We're still accepting new doc patches, and will until the end of beta. --Josh
Bryce Nesbitt wrote: > This is a proposed patch to document disabling the statistics collector > pg_dump activity, and give a bit more visibility to the PGOPTIONS > environment variable supported by libpq. > > It is an alternative to the prior patch, which supplied a --no-stats flag. > > This is a documentation only patch, not tied to a recent code change. Patch applied, with spelling correction already noted. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Re: New pg_dump patch -- document statistics collector exception (REVISED PATCH)
From
Bruce Momjian
Date:
Josh Berkus wrote: > Euler Taveira de Oliveira wrote: > > Bryce Nesbitt escreveu: > >> Here's a revision (thanks Robert Treat for the spelling corrextion). > >> If there are no other objections, how do I nominate it for consideration? > >> > > Added to next commit fest [1]. > > Um, not necessary. We're still accepting new doc patches, and will > until the end of beta. Yep, patch commited, removed from next commit fest. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Apologies. Turns out the name of the relevant setting was changed for 8.3! So a revised patch is attached.
For backing, see:
http://www.postgresql.org/docs/8.3/static/release-8-3.html
" Numerous changes in administrative server parameters...
stats_block_level and stats_row_level are merged into track_counts."
Bruce Momjian wrote:
For backing, see:
http://www.postgresql.org/docs/8.3/static/release-8-3.html
" Numerous changes in administrative server parameters...
stats_block_level and stats_row_level are merged into track_counts."
Bruce Momjian wrote:
Bryce Nesbitt wrote:This is a proposed patch to document disabling the statistics collector pg_dump activity, and give a bit more visibility to the PGOPTIONS environment variable supported by libpq. It is an alternative to the prior patch, which supplied a --no-stats flag. This is a documentation only patch, not tied to a recent code change.Patch applied, with spelling correction already noted.
> Apologies. Turns out the name of the relevant setting was changed > for 8.3! So a revised patch is attached. > For backing, see: > http://www.postgresql.org/docs/8.3/static/release-8-3.html > " Numerous changes in administrative server parameters... > stats_block_level and stats_row_level are merged into track_counts." > Bryce Nesbitt wrote: We don't want a pg_dump flag; the doc mention is good enough. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
Bruce Momjian wrote:
Doh! Try this one instead. Postgres 8.3 changed the name of the flag mentioned in the doc.Apologies. Turns out the name of the relevant setting was changed for 8.3! So a revised patch is attached. For backing, see: http://www.postgresql.org/docs/8.3/static/release-8-3.html " Numerous changes in administrative server parameters... stats_block_level and stats_row_level are merged into track_counts." Bryce Nesbitt wrote:We don't want a pg_dump flag; the doc mention is good enough.
> We don't want a pg_dump flag; the doc mention is good enough. > > > Doh! Try this one instead. Postgres 8.3 changed the name of the > flag mentioned in the doc. [ Please avoid html-only email.] OK, patch applied, but I removed the mention of pre-8.3 because this is going only in the 8.4 docs. Thanks. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +