Thread: Re: [PATCHES] gratuituous string difference

Re: [PATCHES] gratuituous string difference

From
Tom Lane
Date:
Alvaro Herrera <alvherre@commandprompt.com> writes:
> This patch fixes a gratuituous string difference.  Barring objections
> I'll apply shortly.

I object.  We do not quote the output of format_type_be() ... look at
its code to see why not.

            regards, tom lane

Re: [PATCHES] gratuituous string difference

From
Alvaro Herrera
Date:
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > This patch fixes a gratuituous string difference.  Barring objections
> > I'll apply shortly.
>
> I object.  We do not quote the output of format_type_be() ... look at
> its code to see why not.

Oh, I see -- it may add double quotes on its own in certain cases, while
the other string gets the input from TypeNameToString which never does.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support