Re: [PATCHES] gratuituous string difference - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCHES] gratuituous string difference
Date
Msg-id 20061129194452.GB7001@alvh.no-ip.org
Whole thread Raw
In response to Re: [PATCHES] gratuituous string difference  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > This patch fixes a gratuituous string difference.  Barring objections
> > I'll apply shortly.
>
> I object.  We do not quote the output of format_type_be() ... look at
> its code to see why not.

Oh, I see -- it may add double quotes on its own in certain cases, while
the other string gets the input from TypeNameToString which never does.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: VPATH problems in ECPG again
Next
From: Stefan Kaltenbrunner
Date:
Subject: -HEAD configure issue with libedit on linux