Thread: Re: [PATCHES] Avg performance for int8/numeric

Re: [PATCHES] Avg performance for int8/numeric

From
Tom Lane
Date:
Neil Conway <neilc@samurai.com> writes:
> On Fri, 2006-11-24 at 11:08 +1300, Mark Kirkwood wrote:
>> - Modifies do_numeric_accum to have an extra bool parameter and does not
>> calc sumX2 when it is false.

> I think it would be clearer to reorganize this function slightly, and
> have only a single branch on "useSumX2".

It would be clearer to just have a separate function.

            regards, tom lane