Re: [PATCHES] Avg performance for int8/numeric - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Avg performance for int8/numeric
Date
Msg-id 28127.1164341892@sss.pgh.pa.us
Whole thread Raw
List pgsql-hackers
Neil Conway <neilc@samurai.com> writes:
> On Fri, 2006-11-24 at 11:08 +1300, Mark Kirkwood wrote:
>> - Modifies do_numeric_accum to have an extra bool parameter and does not
>> calc sumX2 when it is false.

> I think it would be clearer to reorganize this function slightly, and
> have only a single branch on "useSumX2".

It would be clearer to just have a separate function.

            regards, tom lane

pgsql-hackers by date:

Previous
From: "Andrew Dunstan"
Date:
Subject: Re: 8.2 open items list
Next
From: Euler Taveira de Oliveira
Date:
Subject: Re: Day and month name localization uses wrong locale category