Thread: Re: [PATCHES] Proposed patch for contrib/cube

Re: [PATCHES] Proposed patch for contrib/cube

From
Tom Lane
Date:
Joshua Reich <josh@root.net> writes:
>> if (PG_ARGISNULL(0) || PG_ARGISNULL(1))
>> {
>> ereport(ERROR,
>> (errcode(ERRCODE_ARRAY_ELEMENT_ERROR),
>> errmsg("Cannot work with NULL arrays")));
>> }

This is useless code if the function is declared STRICT, as C functions
most often are.  What you *do* need to be checking is ARR_HASNULL(),
since there isn't anything very useful you can do with null elements
within the arrays.

            regards, tom lane