Re: [PATCHES] Proposed patch for contrib/cube - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Proposed patch for contrib/cube
Date
Msg-id 8960.1153176086@sss.pgh.pa.us
Whole thread Raw
List pgsql-hackers
Joshua Reich <josh@root.net> writes:
>> if (PG_ARGISNULL(0) || PG_ARGISNULL(1))
>> {
>> ereport(ERROR,
>> (errcode(ERRCODE_ARRAY_ELEMENT_ERROR),
>> errmsg("Cannot work with NULL arrays")));
>> }

This is useless code if the function is declared STRICT, as C functions
most often are.  What you *do* need to be checking is ARR_HASNULL(),
since there isn't anything very useful you can do with null elements
within the arrays.

            regards, tom lane

pgsql-hackers by date:

Previous
From: "Marc G. Fournier"
Date:
Subject: Re: plPHP and plRuby
Next
From: Tom Lane
Date:
Subject: Re: src/tools/pginclude considered harmful (was Re: