Thread: Re: [PATCHES] Fix for running from admin account on win32

You'll still need to run the postmaster frmo pg_ctl to get the "run as
admin" part. The only part that could be moved is the Job Object for
management. And you're normally not going to need that one when you're
not running as a service. Maybe sometimes, but I doubt it's worth it. If
we could solve the run-as-admin inside the postmaster it might be
different, but AFAICS we can't.

//Magnus


> -----Original Message-----
> From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
>
>
> Where are we on this patch?
>
> I am thinking it should be in the most logical place, rather
> than in pg_ctl.  One call isn't a big deal, especially if you
> can run the postmaster without using pg_ctl.
>
> --------------------------------------------------------------
> -------------
>
> Magnus Hagander wrote:
> > > > If the job object code is moved to the postmaster, it'll
> > > work when not
> > > > running as a service as well.
> > >
> > > I'd just as soon keep all that Windows-specific cruft in pg_ctl.
> > > So I think the way you've got it set up is fine.
> >
> > Well, it'd all be localised to the backend/port/win32 directory of
> > course, except for a single call - where there is already "windows
> > cruft".
> >
> > But. I see your point. And the  vast majority of production
> > installations run as service anyway. So I won't spend any
> time making
> > those changes, I'll leave what's on -patches now.
> >
> > //Magnus
> >
> > ---------------------------(end of
> > broadcast)---------------------------
> > TIP 5: don't forget to increase your free space map settings
> >
>
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman@candle.pha.pa.us               |  (610) 359-1001
>   +  If your life is a hard drive,     |  13 Roberts Road
>   +  Christ can be your backup.        |  Newtown Square,
> Pennsylvania 19073
>

"Magnus Hagander" <mha@sollentuna.net> writes:
> You'll still need to run the postmaster frmo pg_ctl to get the "run as
> admin" part. The only part that could be moved is the Job Object for
> management. And you're normally not going to need that one when you're
> not running as a service. Maybe sometimes, but I doubt it's worth it. If
> we could solve the run-as-admin inside the postmaster it might be
> different, but AFAICS we can't.

Yeah, I thought we'd agreed that the patch was fine as-is.

            regards, tom lane

Tom Lane wrote:
> "Magnus Hagander" <mha@sollentuna.net> writes:
> > You'll still need to run the postmaster frmo pg_ctl to get the "run as
> > admin" part. The only part that could be moved is the Job Object for
> > management. And you're normally not going to need that one when you're
> > not running as a service. Maybe sometimes, but I doubt it's worth it. If
> > we could solve the run-as-admin inside the postmaster it might be
> > different, but AFAICS we can't.
>
> Yeah, I thought we'd agreed that the patch was fine as-is.

Fine. I just wanted to make sure the decions was being made in terms of
logic, rather than Win32 cruft avoidance.  The previous discussion was
not clear on this point.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073