Thread: FW: PGBuildfarm member snake Branch HEAD Status changed from OK to Contrib failure
FW: PGBuildfarm member snake Branch HEAD Status changed from OK to Contrib failure
From
"Dave Page"
Date:
Looks like there more unprotable code in the recent changes to pgbench :-( Regards, Dave. > -----Original Message----- > From: pgbuildfarm-web@hosting-two.commandprompt.com > [mailto:pgbuildfarm-web@hosting-two.commandprompt.com] > Sent: 30 September 2005 02:17 > To: pgbuildfarm-status-chngs@pgfoundry.org; > pgbuildfarm-status-green@pgfoundry.org > Subject: PGBuildfarm member snake Branch HEAD Status changed > from OK to Contrib failure > > > The PGBuildfarm member snake had the following event on branch HEAD: > > Status changed from OK to Contrib failure > > The snapshot timestamp for the build that triggered this > notification is: 2005-09-30 01:00:01 > > The specs of this machine are: > OS: Windows / Server 2003 SP1 > Arch: i686 > Comp: gcc / 3.4.2 > > For more information, see > http://www.pgbuildfarm.org/cgi-bin/show_history.pl?nm=snake&br=HEAD > >
Re: FW: PGBuildfarm member snake Branch HEAD Status changed from OK to Contrib failure
From
Alvaro Herrera
Date:
On Fri, Sep 30, 2005 at 10:08:11AM +0100, Dave Page wrote: > Looks like there more unprotable code in the recent changes to pgbench > :-( Here, the culprits are tfind() and tsearch(). These apparently aren't "portable enough", but they seem to exist on all other platforms. Maybe we could come up with a replacement on Windows? Are there simple btree/hash table functions on Windows, with a similar API? -- Alvaro Herrera Architect, http://www.EnterpriseDB.com La web junta la gente porque no importa que clase de mutante sexual seas, tienes millones de posibles parejas. Pon "buscar gente que tengan sexo con ciervos incendiándose", y el computador dirá "especifique el tipo de ciervo" (Jason Alexander)
Alvaro Herrera wrote: >On Fri, Sep 30, 2005 at 10:08:11AM +0100, Dave Page wrote: > > >>Looks like there more unprotable code in the recent changes to pgbench >>:-( >> >> > >Here, the culprits are tfind() and tsearch(). These apparently aren't >"portable enough", but they seem to exist on all other platforms. Maybe >we could come up with a replacement on Windows? Are there simple >btree/hash table functions on Windows, with a similar API? > > Not that I can see, looking here: http://msdn.microsoft.com/library/en-us/vclib/html/vcrefRunTimeLibraryReference.asp The library found at http://sourceforge.net/project/shownotes.php?release_id=209006 seems to have what is needed, but I really don't think we can impose that extra requirement at this stage of the release cycle, do you? ISTM either we need to revert this or change it to use an API that is already known to be supported. cheers andrew
Andrew Dunstan <andrew@dunslane.net> writes: > Alvaro Herrera wrote: >> Here, the culprits are tfind() and tsearch(). These apparently aren't >> "portable enough", but they seem to exist on all other platforms. Maybe >> we could come up with a replacement on Windows? Are there simple >> btree/hash table functions on Windows, with a similar API? > The library found at > http://sourceforge.net/project/shownotes.php?release_id=209006 seems to > have what is needed, but I really don't think we can impose that extra > requirement at this stage of the release cycle, do you? ISTM either we > need to revert this or change it to use an API that is already known to > be supported. Yeah, I was wondering about those functions too when I looked at the patch. ISTM that this is overkill anyway; I cannot imagine anyone writing a pgbench script with more than a few variables. So I'd recommend ripping out the <search.h> stuff altogether and just making a linear search through a simple array of variables. regards, tom lane