Re: FW: PGBuildfarm member snake Branch HEAD Status changed - Mailing list pgsql-hackers

From Tom Lane
Subject Re: FW: PGBuildfarm member snake Branch HEAD Status changed
Date
Msg-id 9351.1128186829@sss.pgh.pa.us
Whole thread Raw
In response to Re: FW: PGBuildfarm member snake Branch HEAD Status changed  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> Alvaro Herrera wrote:
>> Here, the culprits are tfind() and tsearch().  These apparently aren't
>> "portable enough", but they seem to exist on all other platforms.  Maybe
>> we could come up with a replacement on Windows?  Are there simple
>> btree/hash table functions on Windows, with a similar API?

> The library found at 
> http://sourceforge.net/project/shownotes.php?release_id=209006 seems to 
> have what is needed, but I really don't think we can impose that extra 
> requirement at this stage of the release cycle, do you? ISTM either we 
> need to revert this or change it to use an API that is already known to 
> be supported.

Yeah, I was wondering about those functions too when I looked at the
patch.  ISTM that this is overkill anyway; I cannot imagine anyone
writing a pgbench script with more than a few variables.  So I'd
recommend ripping out the <search.h> stuff altogether and just making a
linear search through a simple array of variables.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] Proposed patch for sequence-renaming problems
Next
From: Tom Lane
Date:
Subject: Re: Expression index ignores column statistics target