Postgres Pro
Downloads
Home   >   mailing lists

Thread: pg_dump COMMENT ON DATABASE sometimes inappropriate

pg_dump COMMENT ON DATABASE sometimes inappropriate

From
Michael Fuhr
Date:
pg_dump emits COMMENT ON DATABASE (if the database has a comment)
even when dumping only an individual schema or table.  That seems
inappropriate, especially when copying data to a different cluster
where the named database might not exist or might have a different
comment that shouldn't be overwritten.  Does anybody else think
pg_dump shouldn't emit COMMENT ON DATABASE in these cases?

-- 
Michael Fuhr

Re: pg_dump COMMENT ON DATABASE sometimes inappropriate

From
Robert Treat
Date:
On Wednesday 21 September 2005 01:10, Michael Fuhr wrote:
> pg_dump emits COMMENT ON DATABASE (if the database has a comment)
> even when dumping only an individual schema or table.  That seems
> inappropriate, especially when copying data to a different cluster
> where the named database might not exist or might have a different
> comment that shouldn't be overwritten.  Does anybody else think
> pg_dump shouldn't emit COMMENT ON DATABASE in these cases?

+1

-- 
Robert Treat
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

Re: pg_dump COMMENT ON DATABASE sometimes inappropriate

From
Tom Lane
Date:
Michael Fuhr <mike@fuhr.org> writes:
> pg_dump emits COMMENT ON DATABASE (if the database has a comment)
> even when dumping only an individual schema or table.  That seems
> inappropriate,

Agreed, this seems like a bug.  Fix applied.
        regards, tom lane