Thread: Patch Count?
Marc and/or Bruce: Hey, for my information (people ask me this a lot) can one of you do a count of patch submitters for 8.0? For 7.4, it was around 180. -- Josh Berkus Aglio Database Solutions San Francisco
Josh Berkus wrote: > Marc and/or Bruce: > > Hey, for my information (people ask me this a lot) can one of you do a count > of patch submitters for 8.0? For 7.4, it was around 180. How do you get the count? CVS names at the tail of the commit? -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
Marc, > How do you get the count? CVS names at the tail of the commit? I don't know; Marc and you did it. I'm looking for the number of *people*, not the number of patches. So part of it would come from your mailbox. --Josh -- __Aglio Database Solutions_______________ Josh Berkus Consultant josh@agliodbs.com www.agliodbs.com Ph: 415-752-2500 Fax: 415-752-2387 2166 Hayes Suite 200 San Francisco, CA
Josh Berkus wrote: > Marc, > > > How do you get the count? CVS names at the tail of the commit? > > I don't know; Marc and you did it. I'm looking for the number of *people*, > not the number of patches. So part of it would come from your mailbox. I didn't do it, but it might have been a guess of mine. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
yOn Fri, 4 Feb 2005, Bruce Momjian wrote: > Josh Berkus wrote: >> Marc, >> >>> How do you get the count? CVS names at the tail of the commit? >> >> I don't know; Marc and you did it. I'm looking for the number of *people*, >> not the number of patches. So part of it would come from your mailbox. > > I didn't do it, but it might have been a guess of mine. Ya, I don't recall doing it either :) But let me see if I can come up with some *very* rought #s ... ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email: scrappy@hub.org Yahoo!: yscrappy ICQ: 7615664
Josh Berkus <josh@agliodbs.com> writes:
>> How do you get the count? CVS names at the tail of the commit?
> I don't know; Marc and you did it. I'm looking for the number of *people*,
> not the number of patches. So part of it would come from your mailbox.
Trolling through the pgsql-patches archives might work to count the
number of different people who submitted patches. The number of those
whose work got accepted would be a bit lower of course. If you want the
latter you probably have to troll the CVS logs --- and I'd be a bit
worried that we might have failed to credit some patches properly in the
CVS entries. Are you after an optimistic number or a pessimistic one?
regards, tom lane
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> I didn't do it, but it might have been a guess of mine. > > Ya, I don't recall doing it either :) I did it last time. It's been a while now, but I think what I did was basically look at all the commit messages from the previous release to the current one, and then used a perl script to extract everything that looked like a name or an email address. Then I manually went through and cleaned things up by verifying names, removing duplicates, etc. This relies on the actual commiter giving credit to the patcher, but everyone here is really good about doing that. :) Not sure if I still have the script around, but I can dig it up if it's needed. - -- Greg Sabino Mullane greg@turnstep.com PGP Key: 0x14964AC8 200502050103 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -----BEGIN PGP SIGNATURE----- iD8DBQFCBGHvvJuQZxSWSsgRAlZTAJ9tyRvXsqoHx25ZF5cDQ7vnV9hiNQCgh+oS 7Bq7h4IKPzfIS5P1vVB+B/g= =jEwx -----END PGP SIGNATURE-----
On Sat, 5 Feb 2005, Greg Sabino Mullane wrote:
> I did it last time. It's been a while now, but I think what I
> did was basically look at all the commit messages from the
> previous release to the current one, and then used a perl script
> to extract everything that looked like a name or an email
> address. Then I manually went through and cleaned things up by
> verifying names, removing duplicates, etc. This relies on the
> actual commiter giving credit to the patcher, but everyone
> here is really good about doing that. :) Not sure if I still have
> the script around, but I can dig it up if it's needed.
I'm trying the following on the archives:
grep From: `find 2004-* 2003-1[12] -type f -name "msg*" -exec grep --silent "^diff " {} \; -print` | \ awk -F:
'{print$3}' | \ sed 's/<\/em>//g' | \ sed 's/</ /' | \ awk '{printf"%s %s\n", $1, $2}' | \
sort-u
The problem with commit logs is that a good portion are just 'reports
from' vs patches ... neither method will necessarily be particularly
accurate :)
----
Marc G. Fournier Hub.Org Networking Services (http://www.hub.org)
Email: scrappy@hub.org Yahoo!: yscrappy ICQ: 7615664
On Sat, 5 Feb 2005, Marc G. Fournier wrote: > But let me see if I can come up with some *very* rought #s ... 57 ... Alvaro Herrera Andreas Pflug Andrew Dunstan Andrew Hammond Bruce Momjian Christopher Kings-Lynne Claudio Natoli Dave Page David Fetter Dennis Bjorklund Ed L. Fabien COELHO Gaetano Mendola Gavin Sherry Greg Sabino James William Jan Wieck Jason Tishler Jim Seymour Joe Conway John Hansen Karel Zak Kenneth Marshall Korea PostgreSQL Kris Jurka Kurt Roeckx Larry Rosenman Laurent Ballester Magnus Hagander Mahesh Swamy Manfred Koizar Manfred Spraul Markus Bertheau Martin Münstermann Matthew T. Michael Glaesemann Michael Meskes Neil Conway Nicolai Tufar Oliver Jowett Peter Eisentraut Philip Yarra Reece Hart Reini Urban Robert Treat Rod Taylor Sean Chittenden Sergej Sergeev Simon Riggs Stefan Kaltenbrunner Stephan Szabo Tatsuo Ishii Thomas Hallgren Tom Lane Tony Reina Troels Arvin Zach Irmen ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email: scrappy@hub.org Yahoo!: yscrappy ICQ: 7615664
Using the same search for 7.4 shows only 48 patch submitters, based on posts to pgsql-patches ... Aizaz Ahmed Alvaro Herrera Andreas Pflug Andrew Dunstan Barry Lind Bertrand Petit Bruce Momjian Bruno Wolff Christopher Browne Christopher Kings-Lynne Dave Cramer Dennis Björklund Fernando Nasser Gavin Sherry Hal Snyder Heikki Linnakangas Ivar Jan Wieck Jason Tishler Jeroen T. Joe Conway Jonathan Bartlett Josh Berkus Josh Wilmes Karel Zak Kevin Brown Kim Ho Kris Jurka Kurt Roeckx Larry Rosenman Lee Kindness Manfred Koizar Manfred Spraul Michael Graff Michael Meskes Neil Conway Nic Ferrier Nigel J. Nigel Kukard Patrick Welche Peter Eisentraut Robert Treat Roberto Mello Rod Taylor Ron Mayer Sean Chittenden Tom Lane Troels Arvin
I think I'm telling you what you already know, but there are lots of names missing from that list (myself included), so that process isn't going to work. Matthew Marc G. Fournier wrote: > > Using the same search for 7.4 shows only 48 patch submitters, based on > posts to pgsql-patches ... > > Aizaz Ahmed > Alvaro Herrera > Andreas Pflug > Andrew Dunstan > Barry Lind > Bertrand Petit > Bruce Momjian > Bruno Wolff > Christopher Browne > Christopher Kings-Lynne > Dave Cramer > Dennis Björklund > Fernando Nasser > Gavin Sherry > Hal Snyder > Heikki Linnakangas > Ivar Jan Wieck > Jason Tishler > Jeroen T. > Joe Conway > Jonathan Bartlett > Josh Berkus > Josh Wilmes > Karel Zak > Kevin Brown > Kim Ho > Kris Jurka > Kurt Roeckx > Larry Rosenman > Lee Kindness > Manfred Koizar > Manfred Spraul > Michael Graff > Michael Meskes > Neil Conway > Nic Ferrier > Nigel J. > Nigel Kukard > Patrick Welche > Peter Eisentraut > Robert Treat > Roberto Mello > Rod Taylor > Ron Mayer > Sean Chittenden > Tom Lane > Troels Arvin > > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org >
On Sat, 5 Feb 2005, Matthew T. O'Connor wrote: > I think I'm telling you what you already know, but there are lots of names > missing from that list (myself included), so that process isn't going to > work. When you submit'd your patch, where did you submit this to? As I said, this list is of all those that submit'd patches to pgsql-patches itself, not any of the other lists ... if you did send it to pgsql-patches, please let me know the URL for the message, so that I can see what it was overlooked, and see if I can't improve the 'search' ... > > Matthew > > > Marc G. Fournier wrote: > >> >> Using the same search for 7.4 shows only 48 patch submitters, based on >> posts to pgsql-patches ... >> >> Aizaz Ahmed >> Alvaro Herrera >> Andreas Pflug >> Andrew Dunstan >> Barry Lind >> Bertrand Petit >> Bruce Momjian >> Bruno Wolff >> Christopher Browne >> Christopher Kings-Lynne >> Dave Cramer >> Dennis Björklund >> Fernando Nasser >> Gavin Sherry >> Hal Snyder >> Heikki Linnakangas >> Ivar Jan Wieck >> Jason Tishler >> Jeroen T. >> Joe Conway >> Jonathan Bartlett >> Josh Berkus >> Josh Wilmes >> Karel Zak >> Kevin Brown >> Kim Ho >> Kris Jurka >> Kurt Roeckx >> Larry Rosenman >> Lee Kindness >> Manfred Koizar >> Manfred Spraul >> Michael Graff >> Michael Meskes >> Neil Conway >> Nic Ferrier >> Nigel J. >> Nigel Kukard >> Patrick Welche >> Peter Eisentraut >> Robert Treat >> Roberto Mello >> Rod Taylor >> Ron Mayer >> Sean Chittenden >> Tom Lane >> Troels Arvin >> >> >> ---------------------------(end of broadcast)--------------------------- >> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org >> > ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email: scrappy@hub.org Yahoo!: yscrappy ICQ: 7615664
Marc G. Fournier wrote: > On Sat, 5 Feb 2005, Matthew T. O'Connor wrote: > >> I think I'm telling you what you already know, but there are lots of >> names missing from that list (myself included), so that process isn't >> going to work. > > > When you submit'd your patch, where did you submit this to? As I > said, this list is of all those that submit'd patches to pgsql-patches > itself, not any of the other lists ... if you did send it to > pgsql-patches, please let me know the URL for the message, so that I > can see what it was overlooked, and see if I can't improve the > 'search' ... Well I'm positive I submitted all my pg_autovacuum patches to the patches list, however searching the archives for autovacuum I can't find anything that old. How far back to the searchable archives go?
On Sat, 5 Feb 2005, Matthew T. O'Connor wrote: > Marc G. Fournier wrote: > >> On Sat, 5 Feb 2005, Matthew T. O'Connor wrote: >> >>> I think I'm telling you what you already know, but there are lots of names >>> missing from that list (myself included), so that process isn't going to >>> work. >> >> >> When you submit'd your patch, where did you submit this to? As I said, >> this list is of all those that submit'd patches to pgsql-patches itself, >> not any of the other lists ... if you did send it to pgsql-patches, please >> let me know the URL for the message, so that I can see what it was >> overlooked, and see if I can't improve the 'search' ... > > > Well I'm positive I submitted all my pg_autovacuum patches to the patches > list, however searching the archives for autovacuum I can't find anything > that old. How far back to the searchable archives go? back to 96 or so ... :) ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email: scrappy@hub.org Yahoo!: yscrappy ICQ: 7615664
Marc G. Fournier wrote: > On Sat, 5 Feb 2005, Matthew T. O'Connor wrote: > >> Well I'm positive I submitted all my pg_autovacuum patches to the >> patches list, however searching the archives for autovacuum I can't >> find anything that old. How far back to the searchable archives go? > > > back to 96 or so ... :) I have noticed holes in the archives in the past though; mail that I sent and was delivered back to me wasn't appearing in the archives. I seem to remember it was a particular time period that was missing but I can't remember the exact details. -O
Hi Marc, > > > I think I'm telling you what you already know, but there are lots > of names > > missing from that list (myself included), so that process isn't > going to > > work. > Me too. Maybe some improvement in the routine. > When you submit'd your patch, where did you submit this to? As I > said, > this list is of all those that submit'd patches to pgsql-patches > itself, > not any of the other lists ... if you did send it to pgsql-patches, > please > let me know the URL for the message, so that I can see what it was > overlooked, and see if I can't improve the 'search' ... > You just consider the plain text attachments. What about the encoded attachments [1] and the gziped [2] ones? IMO you need to filter out all sorts of attachments that could be possible (grep in the 'Content-Type:' could solve this) then choose the kind of attachments accepted as 'patches'. So using this approach and yours (grep plain text attachments) can lead to a reasonable result. [1] http://archives.postgresql.org/pgsql-patches/2004-05/msg00377.php [2] http://archives.postgresql.org/pgsql-patches/2005-01/msg00217.php ===== Euler Taveira de Oliveira euler[at]yahoo_com_br __________________________________________________ Converse com seus amigos em tempo real com o Yahoo! Messenger http://br.download.yahoo.com/messenger/
Euler Taveira de Oliveira <eulerto@yahoo.com.br> writes:
> You just consider the plain text attachments. What about the encoded
> attachments [1] and the gziped [2] ones?
And what of people who sent patches in-line (not as MIME-ified
attachments)? Or who sent them to -hackers instead of -patches?
Trolling -hackers for attachments would require a deal of manual
attention, unfortunately, because a lot of messages of that kind
would be bug reports not patches. I'm not real sure that there
aren't some non-patch attachments on -patches as well.
regards, tom lane
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Josh Berkus originally wrote: > Hey, for my information (people ask me this a lot) can one of you do a count > of patch submitters for 8.0? For 7.4, it was around 180. Perhaps this is the gist of the problem: the 180 count was not "patch submitters" but "people who helped develop 7.4" whether or not they actually submitted a bona fide patch. If it was just patches, the number would probably be about 50 or so, I would estimate. It's certainly a fuzzy line, but I'd argue that somebody who points out a memory leak that is subsequently patched by Tom should get credit as a "developer", even if no actual patch was submitted. I'll give it a go for 8.0 and see what number I come up with. - -- Greg Sabino Mullane greg@turnstep.com PGP Key: 0x14964AC8 200502061348 http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 -----BEGIN PGP SIGNATURE----- iD8DBQFCBmhrvJuQZxSWSsgRAhkdAKDHI2GkbvN7TEq8tx+IYfUG6DDo2ACgz3HU DB4beMEqQEPBN+0lKP0bAuI= =RSNX -----END PGP SIGNATURE-----
This thread somehow reminds me how the company I'm working for tries to measure my profitability: lines of code edited, number of bugs fixed in what time, and other odd things :-) Sorry if this is the wrong subject ... Greg Sabino Mullane schrieb: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > Josh Berkus originally wrote: > >>Hey, for my information (people ask me this a lot) can one of you do a count >>of patch submitters for 8.0? For 7.4, it was around 180. > > > Perhaps this is the gist of the problem: the 180 count was not "patch > submitters" but "people who helped develop 7.4" whether or not they actually > submitted a bona fide patch. If it was just patches, the number would > probably be about 50 or so, I would estimate. It's certainly a fuzzy line, > but I'd argue that somebody who points out a memory leak that is subsequently > patched by Tom should get credit as a "developer", even if no actual patch > was submitted. > > I'll give it a go for 8.0 and see what number I come up with. > > - -- > Greg Sabino Mullane greg@turnstep.com > PGP Key: 0x14964AC8 200502061348 > http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8 > > -----BEGIN PGP SIGNATURE----- > > iD8DBQFCBmhrvJuQZxSWSsgRAhkdAKDHI2GkbvN7TEq8tx+IYfUG6DDo2ACgz3HU > DB4beMEqQEPBN+0lKP0bAuI= > =RSNX > -----END PGP SIGNATURE----- > > > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) >
On Sun, 6 Feb 2005, Greg Sabino Mullane wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > Josh Berkus originally wrote: >> Hey, for my information (people ask me this a lot) can one of you do a count >> of patch submitters for 8.0? For 7.4, it was around 180. > > Perhaps this is the gist of the problem: the 180 count was not "patch > submitters" but "people who helped develop 7.4" whether or not they > actually submitted a bona fide patch. If it was just patches, the number > would probably be about 50 or so, I would estimate. It's certainly a > fuzzy line, but I'd argue that somebody who points out a memory leak > that is subsequently patched by Tom should get credit as a "developer", > even if no actual patch was submitted. The thing is, once we get to *this* point, then we really need to just count all ppl that posted to -hackers during that time period, as that would include feedback on proposed changes, bug reports, etc ... since, by your definition above, they all became 'developers' as well ... Not saying that this isn't the right approach, just pointing out that 'feedback' on a proposed change isn't much differen then pointing out problems with a current implementation ... ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email: scrappy@hub.org Yahoo!: yscrappy ICQ: 7615664
Marc G. Fournier wrote: > > please let me know the URL for the message, so that I can see what it > was overlooked, and see if I can't improve the 'search' ... Marc - here is one I submitted that was not picked up :-) http://archives.postgresql.org/pgsql-patches/2005-01/msg00145.php regards Mark
Hi Tom, > Trolling -hackers for attachments would require a deal of manual > attention, unfortunately, because a lot of messages of that kind > would be bug reports not patches. I'm not real sure that there > aren't some non-patch attachments on -patches as well. > That's why we need a Bug Tracking System. It was discussed some time ago and what is the clue? IMHO A BTS is an essencial part in the software development process. ===== Euler Taveira de Oliveira euler[at]yahoo_com_br __________________________________________________ Converse com seus amigos em tempo real com o Yahoo! Messenger http://br.download.yahoo.com/messenger/
On Sun, 6 Feb 2005, Euler Taveira de Oliveira wrote: > Hi Tom, > >> Trolling -hackers for attachments would require a deal of manual >> attention, unfortunately, because a lot of messages of that kind >> would be bug reports not patches. I'm not real sure that there >> aren't some non-patch attachments on -patches as well. >> > > That's why we need a Bug Tracking System. It was discussed some time > ago and what is the clue? IMHO A BTS is an essencial part in the > software development process. So that we can count # of patch submitters? :) ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email: scrappy@hub.org Yahoo!: yscrappy ICQ: 7615664