Thread: pg_restore --help
People, In pg_restore --help I see this: -O, --no-owner do not output commands to set object ownership [...] -x, --no-privileges skip restoration of access privileges (grant/revoke) Do we talk about "output commands" to do things, or directly about restoration? I think -O description should be -O, --no-owner skip restoration of object ownership or something similar, to be consistent. Patch for that attached, but feel free to editorialize ... -- Alvaro Herrera (<alvherre[a]dcc.uchile.cl>) "The ability to monopolize a planet is insignificant next to the power of the source"
Attachment
Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
> Do we talk about "output commands" to do things, or directly about
> restoration? I think -O description should be
> -O, --no-owner skip restoration of object ownership
This seems reasonable, but I wonder whether we should hold it for 8.1.
There hasn't been any official declaration that translatable strings
are frozen for 8.0 --- but are we at that point yet? Even if we're
not at hard freeze, minor wording improvements might be out.
Peter, I'll defer to your judgment on this ...
regards, tom lane
On Fri, Dec 03, 2004 at 12:20:51PM -0500, Tom Lane wrote: > This seems reasonable, but I wonder whether we should hold it for 8.1. > There hasn't been any official declaration that translatable strings > are frozen for 8.0 --- but are we at that point yet? Even if we're > not at hard freeze, minor wording improvements might be out. Not sure, I've been holding translations precisely because strings are not frozen yet ... -- Alvaro Herrera (<alvherre[@]dcc.uchile.cl>) "La virtud es el justo medio entre dos defectos" (Aristóteles)
Tom Lane wrote: > Alvaro Herrera <alvherre@dcc.uchile.cl> writes: > > Do we talk about "output commands" to do things, or directly about > > restoration? I think -O description should be > > -O, --no-owner skip restoration of object ownership > > This seems reasonable, but I wonder whether we should hold it for > 8.1. There hasn't been any official declaration that translatable > strings are frozen for 8.0 --- but are we at that point yet? Even if > we're not at hard freeze, minor wording improvements might be out. > > Peter, I'll defer to your judgment on this ... Change it right now, and then we'll freeze. :) -- Peter Eisentraut http://developer.postgresql.org/~petere/
Peter Eisentraut <peter_e@gmx.net> writes:
> Change it right now, and then we'll freeze. :)
Done.
regards, tom lane