Thread: CVS HEAD compile failure

Attached is a compile failure I am seeing in CVS HEAD in bin/pg_dump.
The offending lines are:

    gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/parser'
    gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes -Wmissing-declarations -O1 -Wall -Wmissing-prototypes
-Wmissing-declar
    ations -Wpointer-arith -Wcast-align -I../../../src/interfaces/libpq -I../../../src/include
-I/usr/local/include/readline-I/us 
    r/contrib/include -DBINDIR=\"/usr/local/pgsql/bin\"  -c -o common.o common.c
    In file included from /usr/contrib/include/openssl/comp.h:5,
                     from /usr/contrib/include/openssl/ssl.h:171,
                     from ../../../src/interfaces/libpq/libpq-fe.h:33,
                     from pg_backup.h:30,
                     from pg_backup_archiver.h:58,
                     from common.c:21:
    /usr/contrib/include/openssl/crypto.h:358: syntax error before `free_func'
    /usr/contrib/include/openssl/crypto.h:358: syntax error before `)'
    /usr/contrib/include/openssl/crypto.h:363: syntax error before `free_func'
    /usr/contrib/include/openssl/crypto.h:363: syntax error before `)'
    In file included from /usr/contrib/include/openssl/rsa.h:62,
                     from /usr/contrib/include/openssl/evp.h:137,
                     from /usr/contrib/include/openssl/x509.h:67,
                     from /usr/contrib/include/openssl/ssl.h:177,
                     from ../../../src/interfaces/libpq/libpq-fe.h:33,
                     from pg_backup.h:30,
                     from pg_backup_archiver.h:58,
                     from common.c:21:
    /usr/contrib/include/openssl/asn1.h:802: syntax error before `free_func'
    /usr/contrib/include/openssl/asn1.h:802: `d2i_ASN1_SET' declared as function returning a function
    /usr/contrib/include/openssl/asn1.h:803: syntax error before `int'
    /usr/contrib/include/openssl/asn1.h:907: syntax error before `free_func'
    /usr/contrib/include/openssl/asn1.h:907: syntax error before `)'
    In file included from /usr/contrib/include/openssl/evp.h:148,
                     from /usr/contrib/include/openssl/x509.h:67,
                     from /usr/contrib/include/openssl/ssl.h:177,
                     from ../../../src/interfaces/libpq/libpq-fe.h:33,
                     from pg_backup.h:30,
                     from pg_backup_archiver.h:58,
                     from common.c:21:

as you can see, these are all related to free_func.    The line in crypto.h is:

    int CRYPTO_set_locked_mem_functions(void *(*m)(size_t), void (*free_func)(void *));

I can't see what could be causing this failure.  I thought maybe
'free_func' was defined in our code, but I don't see it.  Also, there
are earlier references to free_func in that file that aren't marked as
failures.    I looked at the recent changes to pg_dump/Makefile, but
don't see anything.  This is a clean build.

I can compile 7.4.X CVS just fine.  This failure began within the past
few days.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
gmake -C port all
gmake[1]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake[1]: Nothing to be done for `all'.
gmake[1]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake -C backend all
gmake[1]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend'
gmake -C ../../src/port all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake -C access all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access'
gmake -C common SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/common'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/common'
gmake -C gist SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/gist'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/gist'
gmake -C hash SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/hash'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/hash'
gmake -C heap SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/heap'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/heap'
gmake -C index SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/index'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/index'
gmake -C nbtree SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/nbtree'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/nbtree'
gmake -C rtree SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/rtree'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/rtree'
gmake -C transam SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/transam'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access/transam'
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/access'
gmake -C bootstrap all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/bootstrap'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/bootstrap'
gmake -C catalog all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/catalog'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/catalog'
gmake -C parser all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/parser'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/parser'
gmake -C commands all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/commands'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/commands'
gmake -C executor all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/executor'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/executor'
gmake -C lib all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/lib'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/lib'
gmake -C libpq all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/libpq'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/libpq'
gmake -C main all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/main'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/main'
gmake -C nodes all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/nodes'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/nodes'
gmake -C optimizer all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer'
gmake -C geqo SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/geqo'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/geqo'
gmake -C path SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/path'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/path'
gmake -C plan SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/plan'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/plan'
gmake -C prep SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/prep'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/prep'
gmake -C util SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/util'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer/util'
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/optimizer'
gmake -C port all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/port'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/port'
gmake -C postmaster all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/postmaster'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/postmaster'
gmake -C regex all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/regex'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/regex'
gmake -C rewrite all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/rewrite'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/rewrite'
gmake -C storage all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage'
gmake -C buffer SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/buffer'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/buffer'
gmake -C file SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/file'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/file'
gmake -C freespace SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/freespace'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/freespace'
gmake -C ipc SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/ipc'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/ipc'
gmake -C large_object SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/large_object'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/large_object'
gmake -C lmgr SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/lmgr'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/lmgr'
gmake -C page SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/page'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/page'
gmake -C smgr SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/smgr'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage/smgr'
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/storage'
gmake -C tcop all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/tcop'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/tcop'
gmake -C utils all
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils'
gmake -C adt SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/adt'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/adt'
gmake -C cache SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/cache'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/cache'
gmake -C error SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/error'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/error'
gmake -C fmgr SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/fmgr'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/fmgr'
gmake -C hash SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/hash'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/hash'
gmake -C init SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/init'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/init'
gmake -C misc SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/misc'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/misc'
gmake -C mmgr SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mmgr'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mmgr'
gmake -C sort SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/sort'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/sort'
gmake -C time SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/time'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/time'
gmake -C mb SUBSYS.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb'
gmake[3]: `SUBSYS.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb'
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils'
gmake[1]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend'
gmake -C backend/utils/mb/conversion_procs all
gmake[1]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/ascii_and_mic'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/ascii_and_mic'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/cyrillic_and_mic'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/cyrillic_and_mic'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/euc_cn_and_mic'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/euc_cn_and_mic'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/euc_jp_and_sjis'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/euc_jp_and_sjis'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/euc_kr_and_mic'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/euc_kr_and_mic'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/euc_tw_and_big5'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/euc_tw_and_big5'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/latin2_and_win1250'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/latin2_and_win1250'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/latin_and_mic'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/latin_and_mic'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_ascii'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_ascii'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_big5'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_big5'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_cyrillic'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_cyrillic'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_euc_cn'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_euc_cn'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_euc_jp'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_euc_jp'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_euc_kr'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_euc_kr'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_euc_tw'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_euc_tw'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_gb18030'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_gb18030'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_gbk'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_gbk'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_iso8859'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_iso8859'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_iso8859_1'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_iso8859_1'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_johab'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_johab'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_sjis'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_sjis'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_tcvn'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_tcvn'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_uhc'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_uhc'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1250'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1250'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1256'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1256'
gmake[2]: Entering directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win874'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory
`/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win874'
gmake[1]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/utils/mb/conversion_procs'
gmake -C include all
gmake[1]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/include'
gmake[1]: Nothing to be done for `all'.
gmake[1]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/include'
gmake -C interfaces all
gmake[1]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces'
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpq'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpq'
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg'
gmake -C include all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/include'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/include'
gmake -C pgtypeslib all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/pgtypeslib'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/pgtypeslib'
gmake -C ecpglib all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/ecpglib'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/ecpglib'
gmake -C compatlib all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/compatlib'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/compatlib'
gmake -C preproc all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/preproc'
gmake -C ../../../../src/port all
gmake[4]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake[4]: Nothing to be done for `all'.
gmake[4]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/preproc'
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg'
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpgtcl'
gmake -C ../../../src/interfaces/libpq all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpq'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpq'
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpgtcl'
gmake[1]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces'
gmake -C bin all
gmake[1]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin'
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/initdb'
gmake -C ../../../src/interfaces/libpq all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpq'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpq'
gmake -C ../../../src/port all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/initdb'
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/initlocation'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/initlocation'
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/ipcclean'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/ipcclean'
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/pg_ctl'
gmake[2]: Nothing to be done for `all'.
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/pg_ctl'
gmake[2]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/pg_dump'
gmake -C ../../../src/interfaces/libpq all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpq'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/libpq'
gmake -C ../../../src/port all
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/port'
gmake -C ../../../src/backend/parser keywords.o
gmake[3]: Entering directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/parser'
gmake[3]: `keywords.o' is up to date.
gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/parser'
gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes -Wmissing-declarations -O1 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -I../../../src/interfaces/libpq -I../../../src/include
-I/usr/local/include/readline-I/usr/contrib/include -DBINDIR=\"/usr/local/pgsql/bin\"  -c -o common.o common.c 
In file included from /usr/contrib/include/openssl/comp.h:5,
                 from /usr/contrib/include/openssl/ssl.h:171,
                 from ../../../src/interfaces/libpq/libpq-fe.h:33,
                 from pg_backup.h:30,
                 from pg_backup_archiver.h:58,
                 from common.c:21:
/usr/contrib/include/openssl/crypto.h:358: syntax error before `free_func'
/usr/contrib/include/openssl/crypto.h:358: syntax error before `)'
/usr/contrib/include/openssl/crypto.h:363: syntax error before `free_func'
/usr/contrib/include/openssl/crypto.h:363: syntax error before `)'
In file included from /usr/contrib/include/openssl/rsa.h:62,
                 from /usr/contrib/include/openssl/evp.h:137,
                 from /usr/contrib/include/openssl/x509.h:67,
                 from /usr/contrib/include/openssl/ssl.h:177,
                 from ../../../src/interfaces/libpq/libpq-fe.h:33,
                 from pg_backup.h:30,
                 from pg_backup_archiver.h:58,
                 from common.c:21:
/usr/contrib/include/openssl/asn1.h:802: syntax error before `free_func'
/usr/contrib/include/openssl/asn1.h:802: `d2i_ASN1_SET' declared as function returning a function
/usr/contrib/include/openssl/asn1.h:803: syntax error before `int'
/usr/contrib/include/openssl/asn1.h:907: syntax error before `free_func'
/usr/contrib/include/openssl/asn1.h:907: syntax error before `)'
In file included from /usr/contrib/include/openssl/evp.h:148,
                 from /usr/contrib/include/openssl/x509.h:67,
                 from /usr/contrib/include/openssl/ssl.h:177,
                 from ../../../src/interfaces/libpq/libpq-fe.h:33,
                 from pg_backup.h:30,
                 from pg_backup_archiver.h:58,
                 from common.c:21:
/usr/contrib/include/openssl/objects.h:990: syntax error before `free_func'
/usr/contrib/include/openssl/objects.h:990: syntax error before `)'
gmake[2]: *** [common.o] Error 1
gmake[2]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin/pg_dump'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/bin'
gmake: *** [all] Error 2

fresh checkout just compiled fine for me on Linux (RH8) with ssl 
enabled. Maybe it is your openssl installation?

cheers

andrew

Bruce Momjian wrote:

>Attached is a compile failure I am seeing in CVS HEAD in bin/pg_dump. 
>The offending lines are:
>    
>    gmake[3]: Leaving directory `/usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/backend/parser'
>    gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes -Wmissing-declarations -O1 -Wall -Wmissing-prototypes
-Wmissing-declar
>    ations -Wpointer-arith -Wcast-align -I../../../src/interfaces/libpq -I../../../src/include
-I/usr/local/include/readline-I/us
 
>    r/contrib/include -DBINDIR=\"/usr/local/pgsql/bin\"  -c -o common.o common.c
>    In file included from /usr/contrib/include/openssl/comp.h:5,
>                     from /usr/contrib/include/openssl/ssl.h:171,
>                     from ../../../src/interfaces/libpq/libpq-fe.h:33,
>                     from pg_backup.h:30,
>                     from pg_backup_archiver.h:58,
>                     from common.c:21:
>    /usr/contrib/include/openssl/crypto.h:358: syntax error before `free_func'
>    /usr/contrib/include/openssl/crypto.h:358: syntax error before `)'
>    /usr/contrib/include/openssl/crypto.h:363: syntax error before `free_func'
>    /usr/contrib/include/openssl/crypto.h:363: syntax error before `)'
>    In file included from /usr/contrib/include/openssl/rsa.h:62,
>                     from /usr/contrib/include/openssl/evp.h:137,
>                     from /usr/contrib/include/openssl/x509.h:67,
>                     from /usr/contrib/include/openssl/ssl.h:177,
>                     from ../../../src/interfaces/libpq/libpq-fe.h:33,
>                     from pg_backup.h:30,
>                     from pg_backup_archiver.h:58,
>                     from common.c:21:
>    /usr/contrib/include/openssl/asn1.h:802: syntax error before `free_func'
>    /usr/contrib/include/openssl/asn1.h:802: `d2i_ASN1_SET' declared as function returning a function
>    /usr/contrib/include/openssl/asn1.h:803: syntax error before `int'
>    /usr/contrib/include/openssl/asn1.h:907: syntax error before `free_func'
>    /usr/contrib/include/openssl/asn1.h:907: syntax error before `)'
>    In file included from /usr/contrib/include/openssl/evp.h:148,
>                     from /usr/contrib/include/openssl/x509.h:67,
>                     from /usr/contrib/include/openssl/ssl.h:177,
>                     from ../../../src/interfaces/libpq/libpq-fe.h:33,
>                     from pg_backup.h:30,
>                     from pg_backup_archiver.h:58,
>                     from common.c:21:
>    
>as you can see, these are all related to free_func.    The line in crypto.h is:
>
>    int CRYPTO_set_locked_mem_functions(void *(*m)(size_t), void (*free_func)(void *));
>
>I can't see what could be causing this failure.  I thought maybe
>'free_func' was defined in our code, but I don't see it.  Also, there
>are earlier references to free_func in that file that aren't marked as
>failures.    I looked at the recent changes to pg_dump/Makefile, but
>don't see anything.  This is a clean build.
>
>I can compile 7.4.X CVS just fine.  This failure began within the past
>few days.
>
>  
>

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Attached is a compile failure I am seeing in CVS HEAD in bin/pg_dump.

Hmm.  I made some what-I-thought-were-unimportant changes in the order
of header inclusions in pg_dump.  Probably what you are seeing is a
previously unnoticed case of some header that requires some other header
to be included beforehand.  The syntax errors are likely due to a
typedef name not being defined before use.  Does that help?
        regards, tom lane

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Attached is a compile failure I am seeing in CVS HEAD in bin/pg_dump.
> 
> Hmm.  I made some what-I-thought-were-unimportant changes in the order
> of header inclusions in pg_dump.  Probably what you are seeing is a
> previously unnoticed case of some header that requires some other header
> to be included beforehand.  The syntax errors are likely due to a
> typedef name not being defined before use.  Does that help?

Uh, no?  :-)

Where is the typedef here:
 int CRYPTO_set_locked_mem_functions(void *(*m)(size_t), void (*free_func)(void *));

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 

Andrew Dunstan wrote:
> 
> fresh checkout just compiled fine for me on Linux (RH8) with ssl 
> enabled. Maybe it is your openssl installation?

It is openssl 0.9.7c.  7.4 CVS compiles fine so I don't see how it can
be my SSL install.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 

Bruce Momjian wrote:

>Andrew Dunstan wrote:
>  
>
>>fresh checkout just compiled fine for me on Linux (RH8) with ssl 
>>enabled. Maybe it is your openssl installation?
>>    
>>
>
>It is openssl 0.9.7c.  7.4 CVS compiles fine so I don't see how it can
>be my SSL install.
>
>  
>
I just tried with this version of openssl (on RH9), and it still 
compiled fine (CFLAGS=-H shows the right files being picked up).

Can you give us the complete config settings? Maybe some interaction 
between them has found a bug somewhere.

(BTW, the INSTALL file says you can use --with-openssl=/path but 
configure barfs on it - we need to fix one or the other).

cheers

andrew

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Where is the typedef here:
>   int CRYPTO_set_locked_mem_functions(void *(*m)(size_t), void (*free_func)(void *));

size_t ...
        regards, tom lane

Tom Lane wrote:

>Bruce Momjian <pgman@candle.pha.pa.us> writes:
>  
>
>>Where is the typedef here:
>>  int CRYPTO_set_locked_mem_functions(void *(*m)(size_t), void (*free_func)(void *));
>>    
>>
>
>size_t ...
>

If there's a missing typedef shouldn't we see something like this:
   `size_t' undeclared (first use in this function)

(assuming he is using gcc)?


cheers

andrew

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Andrew Dunstan wrote:
>> fresh checkout just compiled fine for me on Linux (RH8) with ssl 
>> enabled. Maybe it is your openssl installation?

> It is openssl 0.9.7c.  7.4 CVS compiles fine so I don't see how it can
> be my SSL install.

I've been able to reproduce this on one of my machines, and it's nasty.
It's a conflict between other people's headers.

/usr/local/include/zlib.h (version 1.1.4) quoth:

typedef void   (*free_func)  OF((voidpf opaque, voidpf address));

/usr/local/ssl/include/openssl/crypto.h (0.9.7c) quoth:

int CRYPTO_set_locked_mem_functions(void *(*m)(size_t), void (*free_func)(void *));

So if this version of zlib.h is included before this version of
crypto.h, things break.  Other way 'round works fine.

We can work around this by being more careful about inclusion order
of these headers.  Ultimately it would be nice if the upstream library
authors could avoid the name conflict.  I'm of the opinion that zlib
should not be typedef'ing a name as generic as "free_func", but if
they've made that part of their exported API, it might be hard for them
to change.
        regards, tom lane

Andrew Dunstan <andrew@dunslane.net> writes:
> (BTW, the INSTALL file says you can use --with-openssl=/path but 

Only because it hasn't yet been rebuilt from installation.sgml.
        regards, tom lane

> >>  int CRYPTO_set_locked_mem_functions(void *(*m)(size_t), void (*free_func)(void *));
> 
> If there's a missing typedef shouldn't we see something like this:
> 
>     `size_t' undeclared (first use in this function)
> 
> (assuming he is using gcc)?

Try it.

typedefs are weird in the C language, they change the syntactical value of the
identifier. The parser actually has to know whether an identifier is a typedef
or not in order to figure out how to parse the code.

Syntax errors in known good code, especially header files are a typical
symptom of missing typedefs. A good thing to know to recognize right away or
else you'll spend lots of time puzzling over seemingly good code.

-- 
greg

Greg Stark <gsstark@mit.edu> writes:
> Syntax errors in known good code, especially header files are a typical
> symptom of missing typedefs. A good thing to know to recognize right away or
> else you'll spend lots of time puzzling over seemingly good code.

Actually it turns out the error was the other way round: a name that the
code did not expect to be a typedef was being taken as one.  But yeah,
"impossible" syntax errors in C code are often a symptom of typedef
trouble.
        regards, tom lane

Tom Lane wrote:

>Bruce Momjian <pgman@candle.pha.pa.us> writes:
>  
>
>>Andrew Dunstan wrote:
>>    
>>
>>>fresh checkout just compiled fine for me on Linux (RH8) with ssl 
>>>enabled. Maybe it is your openssl installation?
>>>      
>>>
>
>  
>
>>It is openssl 0.9.7c.  7.4 CVS compiles fine so I don't see how it can
>>be my SSL install.
>>    
>>
>
>I've been able to reproduce this on one of my machines, and it's nasty.
>It's a conflict between other people's headers.
>
>/usr/local/include/zlib.h (version 1.1.4) quoth:
>
>typedef void   (*free_func)  OF((voidpf opaque, voidpf address));
>
>/usr/local/ssl/include/openssl/crypto.h (0.9.7c) quoth:
>
>int CRYPTO_set_locked_mem_functions(void *(*m)(size_t), void (*free_func)(void *));
>
>So if this version of zlib.h is included before this version of
>crypto.h, things break.  Other way 'round works fine.
>
>We can work around this by being more careful about inclusion order
>of these headers.  Ultimately it would be nice if the upstream library
>authors could avoid the name conflict.  I'm of the opinion that zlib
>should not be typedef'ing a name as generic as "free_func", but if
>they've made that part of their exported API, it might be hard for them
>to change.
>

In that case I'm confused about why this code compiles on my machine:

----------------
#include <stdio.h>
#include <zconf.h>

typedef voidpf (*alloc_func) OF((voidpf opaque, uInt items, uInt size));
typedef void   (*free_func)  OF((voidpf opaque, voidpf address));

int CRYPTO_set_locked_mem_functions(void *(*m)(size_t), void 
(*free_func)(void *));


int main()
{ return 0;
}
--------------------

Also, in compiling pg_dump/common.c, zlib.h (which has this typedef on 
my machine) *is* included before openssl/crypto.h.

Either there is something I'm not getting (quite possible ;-) ), or the 
problem lies deeper. (compiler version maybe?)

cheers

andrew

Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> I've been able to reproduce this on one of my machines, and it's nasty.

> In that case I'm confused about why this code compiles on my machine:

What compiler are you using?  I'm using gcc 2.95.3 (on the machine that
shows the failure), and I think Bruce is also using something less than
the latest.  It's possible that more recent gcc's are able to figure out
that the reference to free_func should be interpreted as a parameter
name and not a typedef.

In fact, trying your test program fails here:

$ gcc -Wall zzz.c
zzz.c:8: parse error before `free_func'
zzz.c:8: parse error before `)'
$ 

so "compiler difference" definitely seems to be the answer.
        regards, tom lane

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>  
>
>>Tom Lane wrote:
>>    
>>
>>>I've been able to reproduce this on one of my machines, and it's nasty.
>>>      
>>>
>
>  
>
>>In that case I'm confused about why this code compiles on my machine:
>>    
>>
>
>What compiler are you using?  I'm using gcc 2.95.3 (on the machine that
>shows the failure), and I think Bruce is also using something less than
>the latest.  It's possible that more recent gcc's are able to figure out
>that the reference to free_func should be interpreted as a parameter
>name and not a typedef.
>
>In fact, trying your test program fails here:
>
>$ gcc -Wall zzz.c
>zzz.c:8: parse error before `free_func'
>zzz.c:8: parse error before `)'
>$ 
>
>so "compiler difference" definitely seems to be the answer.
>
>  
>
gcc version 3.2.2 20030222 (Red Hat Linux 3.2.2-5)

cheers

andrew

On Mon, Dec 08, 2003 at 01:27:35PM -0500, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > Tom Lane wrote:
> >> I've been able to reproduce this on one of my machines, and it's nasty.
> 
> > In that case I'm confused about why this code compiles on my machine:
> 
> What compiler are you using?  I'm using gcc 2.95.3 (on the machine that
> shows the failure)

I can compile current cvs with gcc 2.95.3, openssl 0.9.7b and
zlib 1.2.1.

zlib 1.2.1 still has the same typedef though.


Kurt

Kurt Roeckx wrote:

> On Mon, Dec 08, 2003 at 01:27:35PM -0500, Tom Lane wrote:
>> Andrew Dunstan <andrew@dunslane.net> writes:
>> > Tom Lane wrote:
>> >> I've been able to reproduce this on one of my machines, and it's nasty.
>> 
>> > In that case I'm confused about why this code compiles on my machine:
>> 
>> What compiler are you using?  I'm using gcc 2.95.3 (on the machine that
>> shows the failure)
> 
> I can compile current cvs with gcc 2.95.3, openssl 0.9.7b and
> zlib 1.2.1.
> 
> zlib 1.2.1 still has the same typedef though.

compile success with gcc 2.96 here.


Jan

-- 
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #

Kurt Roeckx <Q@ping.be> writes:
> I can compile current cvs with gcc 2.95.3, openssl 0.9.7b and
> zlib 1.2.1.

"current CVS" meaning "since I fixed the include order" ?
        regards, tom lane

Tom Lane wrote:

> Kurt Roeckx <Q@ping.be> writes:
>> I can compile current cvs with gcc 2.95.3, openssl 0.9.7b and
>> zlib 1.2.1.
> 
> "current CVS" meaning "since I fixed the include order" ?

Good question. Using my cvsup tree here, which I did sup today already. 
So what -D would trigger the failure?


Jan

-- 
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #

Jan Wieck <JanWieck@Yahoo.com> writes:
> Good question. Using my cvsup tree here, which I did sup today already. 
> So what -D would trigger the failure?

Hopefully, you can't ...

If you revert src/bin/pg_dump/pg_backup_archiver.h to version 1.54
you'd see the problem, assuming your compiler is vulnerable.
        regards, tom lane

Tom Lane wrote:

>Kurt Roeckx <Q@ping.be> writes:
>  
>
>>I can compile current cvs with gcc 2.95.3, openssl 0.9.7b and
>>zlib 1.2.1.
>>    
>>
>
>"current CVS" meaning "since I fixed the include order" ?
>

The little code snippet I posted earlier should do to test out 
compilers, if people want to.

Looking around the web I see that we aren't the first people to trip 
over this. In fact the issue has been known for years - I saw a 
reference to it all the way back to 1999.

Another project solved it by adjusting the namespace pollution instead 
of changing the include order, thus:

+#define free_func zlib_free_func#include <zlib.h>
+#undef free_func


Anyway, I hope it's fixed :-)


cheers

andrew

On Monday, December 8, 2003, at 08:29 AM, Tom Lane wrote:
> I'm of the opinion that zlib
> should not be typedef'ing a name as generic as "free_func", but if
> they've made that part of their exported API, it might be hard for them
> to change.

Yes, that was a mistake.  However we're stuck with it to maintain 
interface compatibility.

mark