Thread: Re: [INTERFACES] Patch for DBD::Pg pg_relcheck problem

Re: [INTERFACES] Patch for DBD::Pg pg_relcheck problem

From
Ian Barwick
Date:
(crossposting to hackers)

On Tuesday 10 December 2002 00:47, Tom Lane wrote:
> In the next protocol version update (hopefully 7.4) I would like to see
> the basic version string (eg, "7.3.1" or "7.4devel") delivered to the
> client automatically during connection startup and then available from a
> libpq inquiry function.  This would eliminate the need to call version()
> explicitly and to know that you must skip "PostgreSQL " in its output.

Something along the lines of  char *PQversion(const PGconn *conn) ?

> However, it will only help for clients/libraries that are willing to
> deal exclusively with 7.4-or-newer backends, so it will take a few
> releases to become really useful.

Sounds good to me. Is it on the todo-list? (Couldn't see it there).

Ian Barwick
barwick@gmx.net



Re: [INTERFACES] Patch for DBD::Pg pg_relcheck problem

From
Tom Lane
Date:
Ian Barwick <barwick@gmx.net> writes:
> Sounds good to me. Is it on the todo-list? (Couldn't see it there).

Probably not; Bruce for some reason has resisted listing protocol change
desires as an identifiable TODO category.  There are a couple of threads
in the pghackers archives over the last year or so that discuss the
different things we want to do, though.  (Improving the error-reporting
framework and fixing the COPY protocol are a couple of biggies I can
recall offhand.)
        regards, tom lane


Re: [INTERFACES] Patch for DBD::Pg pg_relcheck problem

From
Lee Kindness
Date:
Ian Barwick writes:> On Tuesday 10 December 2002 00:47, Tom Lane wrote:> > In the next protocol version update
(hopefully7.4) I would like to see> > the basic version string (eg, "7.3.1" or "7.4devel") delivered to the> > client
automaticallyduring connection startup and then available from a> > libpq inquiry function.  This would eliminate the
needto call version()> > explicitly and to know that you must skip "PostgreSQL " in its output.> Something along the
linesof >   char *PQversion(const PGconn *conn) ?
 

Probably:
int PQversion(const PGconn *conn)

would be better, and easier to parse? For example the value returned
for 7.3.1 would be 7003001; for 7.4 7004000; for 101.10.2
101010002. This allows simple numerical tests...

Lee.


Re: [INTERFACES] Patch for DBD::Pg pg_relcheck problem

From
Ian Barwick
Date:
(no followup to dbi-dev@perl.org, getting a little OT there)

On Tuesday 10 December 2002 16:54, Lee Kindness wrote:
> Ian Barwick writes:
>  > Something along the lines of
>  >   char *PQversion(const PGconn *conn) ?
>
> Probably:
>
>  int PQversion(const PGconn *conn)
>
> would be better, and easier to parse? For example the value returned
> for 7.3.1 would be 7003001; for 7.4 7004000; for 101.10.2
> 101010002. This allows simple numerical tests...

Sounds logical - I was evidently thinking in Perl ;-).

For reference pg_dump currently parses the SELECT version() string
into an integer thus:

7.2         70200
7.2.1       70201
7.3devel    70300
7.3rc1      70300
7.3.1       70301
7.3.99      70399
7.399.399  110299
101.10.2  1011002

(and just for fun:
"11i Enterprise Edition with Bells and Whistles "
returns -1 ;-)

which works with minor release numbers of 99
and below.

Ian Barwick
barwick@gmx.net



Re: [INTERFACES] Patch for DBD::Pg pg_relcheck problem

From
Bruce Momjian
Date:
Tom Lane wrote:
> Ian Barwick <barwick@gmx.net> writes:
> > Sounds good to me. Is it on the todo-list? (Couldn't see it there).
> 
> Probably not; Bruce for some reason has resisted listing protocol change
> desires as an identifiable TODO category.  There are a couple of threads
> in the pghackers archives over the last year or so that discuss the
> different things we want to do, though.  (Improving the error-reporting
> framework and fixing the COPY protocol are a couple of biggies I can
> recall offhand.)

Listing protocol changes seemed too low-level for the TODO list, but I
have kept the email messages.  Today I updated the TODO list and added a
section for them.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


Re: [INTERFACES] Patch for DBD::Pg pg_relcheck problem

From
Greg Copeland
Date:
Perhaps compression should be added to the list of protocol changes. 
This way, we can allow for per packet evaluation for compression.


-- 
Greg Copeland <greg@copelandconsulting.net>
Copeland Computer Consulting


On Tue, 2002-12-10 at 21:50, Bruce Momjian wrote:
> Tom Lane wrote:
> > Ian Barwick <barwick@gmx.net> writes:
> > > Sounds good to me. Is it on the todo-list? (Couldn't see it there).
> > 
> > Probably not; Bruce for some reason has resisted listing protocol change
> > desires as an identifiable TODO category.  There are a couple of threads
> > in the pghackers archives over the last year or so that discuss the
> > different things we want to do, though.  (Improving the error-reporting
> > framework and fixing the COPY protocol are a couple of biggies I can
> > recall offhand.)
> 
> Listing protocol changes seemed too low-level for the TODO list, but I
> have kept the email messages.  Today I updated the TODO list and added a
> section for them.




Re: [INTERFACES] Patch for DBD::Pg pg_relcheck problem

From
Bruce Momjian
Date:
Added to TODO.

---------------------------------------------------------------------------

Greg Copeland wrote:
> Perhaps compression should be added to the list of protocol changes. 
> This way, we can allow for per packet evaluation for compression.
> 
> 
> -- 
> Greg Copeland <greg@copelandconsulting.net>
> Copeland Computer Consulting
> 
> 
> On Tue, 2002-12-10 at 21:50, Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Ian Barwick <barwick@gmx.net> writes:
> > > > Sounds good to me. Is it on the todo-list? (Couldn't see it there).
> > > 
> > > Probably not; Bruce for some reason has resisted listing protocol change
> > > desires as an identifiable TODO category.  There are a couple of threads
> > > in the pghackers archives over the last year or so that discuss the
> > > different things we want to do, though.  (Improving the error-reporting
> > > framework and fixing the COPY protocol are a couple of biggies I can
> > > recall offhand.)
> > 
> > Listing protocol changes seemed too low-level for the TODO list, but I
> > have kept the email messages.  Today I updated the TODO list and added a
> > section for them.
> 
> 
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073