Thread: Re: [PORTS] PostgreSQL supported platform report and a

Re: [PORTS] PostgreSQL supported platform report and a

From
"Billy G. Allie"
Date:
Peter Eisentraut wrote:
> Bruce Momjian writes:
> 
> > I am fine with this because it only touches unixware-specific stuff,
> 
> This is an entirely new feature, so it's inappropriate to do now.  And if
> we do it, we should do it for all platforms.

I disagree that it's a new feature.  The code to add the -rpath (-R) option 
was already there.  My patch made it more useful in that the additional search 
libraries are now placed in the -rpath (-R) option.  As to doing it on all 
platforms, that would be a decision for the maintainers of that platforms port.
It may not be necessary for it to occur on a particular platform.  The patch 
to Makefile.global.in provides the means by which the individual ports can add 
the additional search paths.  It's up to the port maintainers to decide if 
it's needed for their port, IMHO.
-- 
____       | Billy G. Allie    | Domain....: Bill.Allie@mug.org
|  /|      | 7436 Hartwell     | MSN.......: B_G_Allie@email.msn.com
|-/-|----- | Dearborn, MI 48126|
|/  |LLIE  | (313) 582-1540    |



Re: [PORTS] PostgreSQL supported platform report and a

From
Peter Eisentraut
Date:
Billy G. Allie writes:

> I disagree that it's a new feature.  The code to add the -rpath (-R) option
> was already there.  My patch made it more useful in that the additional search
> libraries are now placed in the -rpath (-R) option.

Yeah, you're doing additional things, so it's a new feature.  The fact
that you were able to reuse existing code is commendable but does not
create an exception.

> As to doing it on all platforms, that would be a decision for the
> maintainers of that platforms port.

The "rpath" feature behaves consistently across platforms and PostgreSQL
makes consistent use of it, so it does not qualify as a porting issue.
The last thing I'd want to see is that every platform looks for the
libraries in different ways.

-- 
Peter Eisentraut   peter_e@gmx.net