Thread: Some questions about the NetWare Port - please comment

Hello together,

after some discussions with you and other people I want to add all
changes and additions that i've done with PostgreSQL back to you.
In order to do this I thought of the following way:
(If someone can comment on these ideas this would be great.)

- I've created a folder pgsql/src/NetWare.
- This folder contains a GNU makefile for NetWare to build all the
components.
- currently there are 10 netware specific sourcefiles in this folder.
My idea
is to reduce the number and the size of these files in the future by
enhancing
NetWare and the C libraries on NetWare itself.
- I want to submit one component at a time to you that everybody can
easily
follow what i've changed. I want to start with libpq, the second
component will
be PSQL and so on...
- 3 of the 8 mentioned sourcefiles are files that are heavily changed
for NetWare
and I don't want to change the original files in this case. I think
it's better to have
a copy of these files in the NetWare folder. This gives me the chance
to use some
special features of the NetWare platform without confusing people
working on
other platforms. These files are postmaster.c, pgstat.c and
postgres.c.

Any comments are welcome.

Thank you

Ulrich
---------------------------------- This e-mail is virus scanned Diese e-mail ist virusgeprueft

"Ulrich Neumann" <U_Neumann@gne.de> writes:
> - 3 of the 8 mentioned sourcefiles are files that are heavily changed
> for NetWare and I don't want to change the original files in this
> case. I think it's better to have a copy of these files in the NetWare
> folder. This gives me the chance to use some special features of the
> NetWare platform without confusing people working on other
> platforms. These files are postmaster.c, pgstat.c and postgres.c.

Having port-specific copies of those files strikes me as a maintenance
nightmare.  They change constantly (at least postgres.c and postmaster.c
do).

Why exactly do you need heavy changes in these files?

We could consider breaking down these files into smaller pieces in order
to isolate platform dependencies, perhaps.
        regards, tom lane

Tom Lane wrote:
> "Ulrich Neumann" <U_Neumann@gne.de> writes:
> > - 3 of the 8 mentioned sourcefiles are files that are heavily changed
> > for NetWare and I don't want to change the original files in this
> > case. I think it's better to have a copy of these files in the NetWare
> > folder. This gives me the chance to use some special features of the
> > NetWare platform without confusing people working on other
> > platforms. These files are postmaster.c, pgstat.c and postgres.c.
> 
> Having port-specific copies of those files strikes me as a maintenance
> nightmare.  They change constantly (at least postgres.c and postmaster.c
> do).
> 
> Why exactly do you need heavy changes in these files?
> 
> We could consider breaking down these files into smaller pieces in order
> to isolate platform dependencies, perhaps.

Agreed.  These files change so often that it doesn't really makes sense
for us to ship Netware-specific versions because we can't be sure they
match the original files in functionality.  Perhaps we should publish a
URL so people can download patches to apply on top of our official
releases for Netware.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073