Thread: Re: Problem compiling postgres sql --with-tcl

Tom writes:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > Zeugswetter Andreas SB SD writes:
> >> Second I do not understand why the Makefile in pl/tcl is so complicated,
> >> and not similar e.g. to the plpython one, so the first task should be to
> >> simplify the Makefile to use Makefile.shlib, and not cook it's own soup.
>
> > All the oddities in that makefile are there because presumably some system
> > needed them in the past.
>
> No, it's a historical thing: the Makefile.shlib stuff didn't exist when
> pltcl was developed.  I'm not entirely sure why I didn't try to fold
> pltcl in with the Makefile.shlib approach when we started doing that.
> Possibly I was just thinking "don't fix what ain't broken".  But now
> I'd vote for changing over.

Here is a patch per above thread.
I tested the getDBs function in pgtclsh and a simple pltcl function.

I duplicated the file mkMakefile.tcldefs.sh which is probably not good,
but bin/pgtclsh already did it like that, so ...

Andreas

"Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at> writes:
> Here is a patch per above thread.

Why did you change libpgtcl's build process?  AFAIK no one was claiming
that was broken.

This does not seem the right time to be making undiscussed changes in
Makefile.shlib, either.  What's with that?

            regards, tom lane

Tom Lane writes:

> "Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at> writes:
> > Here is a patch per above thread.
>
> Why did you change libpgtcl's build process?  AFAIK no one was claiming
> that was broken.
>
> This does not seem the right time to be making undiscussed changes in
> Makefile.shlib, either.  What's with that?

I wasn't under the impression that we wanted to get this patch into 7.2.
AFAIK, the Tcl stuff has not built on AIX for quite a while, so it's not a
regression from a previous release.  Moreover, the chances that any
significant number of people will test the Tcl build in the remaining test
period is nearly zero.

-- 
Peter Eisentraut   peter_e@gmx.net