Re: [HACKERS] Problem compiling postgres sql --with-tcl - Mailing list pgsql-patches

From Zeugswetter Andreas SB SD
Subject Re: [HACKERS] Problem compiling postgres sql --with-tcl
Date
Msg-id 46C15C39FEB2C44BA555E356FBCD6FA4212869@m0114.s-mxs.net
Whole thread Raw
Responses Re: [HACKERS] Problem compiling postgres sql --with-tcl  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom writes:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > Zeugswetter Andreas SB SD writes:
> >> Second I do not understand why the Makefile in pl/tcl is so complicated,
> >> and not similar e.g. to the plpython one, so the first task should be to
> >> simplify the Makefile to use Makefile.shlib, and not cook it's own soup.
>
> > All the oddities in that makefile are there because presumably some system
> > needed them in the past.
>
> No, it's a historical thing: the Makefile.shlib stuff didn't exist when
> pltcl was developed.  I'm not entirely sure why I didn't try to fold
> pltcl in with the Makefile.shlib approach when we started doing that.
> Possibly I was just thinking "don't fix what ain't broken".  But now
> I'd vote for changing over.

Here is a patch per above thread.
I tested the getDBs function in pgtclsh and a simple pltcl function.

I duplicated the file mkMakefile.tcldefs.sh which is probably not good,
but bin/pgtclsh already did it like that, so ...

Andreas

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: SunOS patch for memcmp()
Next
From: Brent Verner
Date:
Subject: Re: system catalog relation of a table and a serial sequence