Thread: LIKE is still short some MULTIBYTE code
I finished revising the LIKE operators back into an index-optimizable form. But I notice there is some non-multibyte-aware code that needs to be fixed, specifically the pattern analysis routines in src/backend/utils/adt/selfuncs.c:like_fixed_prefixregex_fixed_prefixlike_selectivityregex_selectivity_subregex_selectivity I don't have time to work on this now, but perhaps someone else would like to fix these... regards, tom lane
Hasn't the [HACKERS] / [GENERAL] crossover thing been resolved yet? I'm not subscribed to hackers. Tom Lane wrote: > > I finished revising the LIKE operators back into an index-optimizable > form. But I notice there is some non-multibyte-aware code that needs > to be fixed, specifically the pattern analysis routines in > src/backend/utils/adt/selfuncs.c: > like_fixed_prefix > regex_fixed_prefix > like_selectivity > regex_selectivity_sub > regex_selectivity > I don't have time to work on this now, but perhaps someone else would > like to fix these... > > regards, tom lane
> I finished revising the LIKE operators back into an index-optimizable > form. But I notice there is some non-multibyte-aware code that needs > to be fixed, specifically the pattern analysis routines in > src/backend/utils/adt/selfuncs.c: > like_fixed_prefix > regex_fixed_prefix > like_selectivity > regex_selectivity_sub > regex_selectivity > I don't have time to work on this now, but perhaps someone else would > like to fix these... I have taken a glance on them. Seems no special multibyte hack is neccesary for them. Also, though limited to small scale data, SELECT using index on multibyte data seems to be working... -- Tatsuo Ishii