Thread: Re: [PATCHES] Re: can't make src/tutorial
Bruce,
On Wed, Aug 08, 2001 at 10:53:14PM -0400, Bruce Momjian wrote:
> Is it safe for all platforms?
To be honest, I did not test it on any platform except for Cygwin.
And, on Cygwin I only verified that the build completed without errors.
Nevertheless, if you compare this patch with my contrib one, you will
see that I'm just doing the same old thing.
Additionally, we have the following:
$ fgrep BE_DLLLIBS src/makefiles/*
src/makefiles/Makefile.win:BE_DLLLIBS= -L$(top_builddir)/src/backend -lpostgres
Does the above convince you? If not, then I'm willing to test under
Linux. Unfortunately, due to a job change, it may be a while before I
have access to a Linux machine...
Jason
--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: jason@tishler.net
Hazlet, NJ 07730 USA WWW: http://www.dothill.com
Hi Bruce, If this patch works such that Cygwin is now operational, and it doesn't break other platforms, should it be applied to the upcoming-7.1.3 so that Cygwin is a valid platform for it (7.1.3)? :-) Regards and best wishes, Justin Clift Jason Tishler wrote: > > Bruce, > > On Wed, Aug 08, 2001 at 10:53:14PM -0400, Bruce Momjian wrote: > > Is it safe for all platforms? > > To be honest, I did not test it on any platform except for Cygwin. > And, on Cygwin I only verified that the build completed without errors. > Nevertheless, if you compare this patch with my contrib one, you will > see that I'm just doing the same old thing. > > Additionally, we have the following: > > $ fgrep BE_DLLLIBS src/makefiles/* > src/makefiles/Makefile.win:BE_DLLLIBS= -L$(top_builddir)/src/backend -lpostgres > > Does the above convince you? If not, then I'm willing to test under > Linux. Unfortunately, due to a job change, it may be a while before I > have access to a Linux machine... > > Jason > > -- > Jason Tishler > Director, Software Engineering Phone: 732.264.8770 x235 > Dot Hill Systems Corp. Fax: 732.264.8798 > 82 Bethany Road, Suite 7 Email: jason@tishler.net > Hazlet, NJ 07730 USA WWW: http://www.dothill.com > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly -- "My grandfather once told me that there are two kinds of people: those who work and those who take the credit. He told me to try to be in the first group; there was less competition there." - Indira Gandhi
Jason Tishler <jason@tishler.net> writes:
> On Wed, Aug 08, 2001 at 10:53:14PM -0400, Bruce Momjian wrote:
>> Is it safe for all platforms?
> To be honest, I did not test it on any platform except for Cygwin.
You can point at plpgsql and the regression tests, both of which contain
the same operation and are certainly well-tested. Or you can point out
that the patch cannot possibly affect any non-Windows platform (since
DLLLIBS is ignored by all other builds), and since src/tutorial is
already reported broken on Windows, there's no possible degradation
if it somehow fails to work.
In short: looks mighty safe to me. Since Bruce seems to be feeling
skittish, I will accept the karmic responsibility of applying it ;-)
regards, tom lane
> Jason Tishler <jason@tishler.net> writes: > > On Wed, Aug 08, 2001 at 10:53:14PM -0400, Bruce Momjian wrote: > >> Is it safe for all platforms? > > > To be honest, I did not test it on any platform except for Cygwin. > > You can point at plpgsql and the regression tests, both of which contain > the same operation and are certainly well-tested. Or you can point out > that the patch cannot possibly affect any non-Windows platform (since > DLLLIBS is ignored by all other builds), and since src/tutorial is > already reported broken on Windows, there's no possible degradation > if it somehow fails to work. > > In short: looks mighty safe to me. Since Bruce seems to be feeling > skittish, I will accept the karmic responsibility of applying it ;-) No, I am fine applying it now that I know it is safe and he wants it applied. The original email was vague on that point. :-) Tom, I see you got it already. Thanks. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> Bruce, > > On Wed, Aug 08, 2001 at 10:53:14PM -0400, Bruce Momjian wrote: > > Is it safe for all platforms? > > To be honest, I did not test it on any platform except for Cygwin. > And, on Cygwin I only verified that the build completed without errors. > Nevertheless, if you compare this patch with my contrib one, you will > see that I'm just doing the same old thing. > > Additionally, we have the following: > > $ fgrep BE_DLLLIBS src/makefiles/* > src/makefiles/Makefile.win:BE_DLLLIBS= -L$(top_builddir)/src/backend -lpostgres > > Does the above convince you? If not, then I'm willing to test under > Linux. Unfortunately, due to a job change, it may be a while before I > have access to a Linux machine... > I will try it once I apply the patch. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026