Thread: pgsql: Add some comments to test_ddl_deparse and a README

Add some comments to test_ddl_deparse and a README

Per comments from Heikki Linnakangas.

Backpatch to 9.5, where this module was introduced.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8f612b7f0042a33f59cd4a18144b4d74e78b6859

Modified Files
--------------
src/test/modules/test_ddl_deparse/README           |    8 ++++++
.../modules/test_ddl_deparse/test_ddl_deparse.c    |   26 ++++++++++++++++++++
2 files changed, 34 insertions(+)

On 07/20/2015 12:21 PM, Alvaro Herrera wrote:
> Add some comments to test_ddl_deparse and a README
>
> Per comments from Heikki Linnakangas.
>
> Backpatch to 9.5, where this module was introduced.

I already added the ReAddComment case there, and you get a compiler
error now:

est_ddl_deparse.c: In function ‘get_altertable_subcmdtypes’:
test_ddl_deparse.c:179:4: error: duplicate case value
     case AT_ReAddComment:
     ^
test_ddl_deparse.c:155:4: error: previously used here
     case AT_ReAddComment:
     ^

I'll let you fix that, so that I won't joggle your elbow again ;-)

- Heikki

Heikki Linnakangas wrote:
> On 07/20/2015 12:21 PM, Alvaro Herrera wrote:
> >Add some comments to test_ddl_deparse and a README
> >
> >Per comments from Heikki Linnakangas.
> >
> >Backpatch to 9.5, where this module was introduced.
>
> I already added the ReAddComment case there, and you get a compiler error
> now:

Wow, I mismerged and failed to realize.  Bah.

> est_ddl_deparse.c: In function ‘get_altertable_subcmdtypes’:
> test_ddl_deparse.c:179:4: error: duplicate case value
>     case AT_ReAddComment:
>     ^
> test_ddl_deparse.c:155:4: error: previously used here
>     case AT_ReAddComment:
>     ^
>
> I'll let you fix that, so that I won't joggle your elbow again ;-)

Thanks

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services