Re: pgsql: Add some comments to test_ddl_deparse and a README - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Add some comments to test_ddl_deparse and a README
Date
Msg-id 20150720095209.GI2301@postgresql.org
Whole thread Raw
In response to Re: pgsql: Add some comments to test_ddl_deparse and a README  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-committers
Heikki Linnakangas wrote:
> On 07/20/2015 12:21 PM, Alvaro Herrera wrote:
> >Add some comments to test_ddl_deparse and a README
> >
> >Per comments from Heikki Linnakangas.
> >
> >Backpatch to 9.5, where this module was introduced.
>
> I already added the ReAddComment case there, and you get a compiler error
> now:

Wow, I mismerged and failed to realize.  Bah.

> est_ddl_deparse.c: In function ‘get_altertable_subcmdtypes’:
> test_ddl_deparse.c:179:4: error: duplicate case value
>     case AT_ReAddComment:
>     ^
> test_ddl_deparse.c:155:4: error: previously used here
>     case AT_ReAddComment:
>     ^
>
> I'll let you fix that, so that I won't joggle your elbow again ;-)

Thanks

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Add some comments to test_ddl_deparse and a README
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Fix mis-merge in previous commit