Thread: pgsql: Add missing index terms for replication commands in the document
Add missing index terms for replication commands in the document. Previously only CREATE_REPLICATION_SLOT was exposed as an index term. That's odd and there is no reason not to add index terms for other replication commands. Back-patch to 9.4. Branch ------ REL9_4_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/3b2f4aa0f0fe23b0cac753f91833df353994d298 Modified Files -------------- doc/src/sgml/protocol.sgml | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-)
Re: pgsql: Add missing index terms for replication commands in the document
From
Michael Paquier
Date:
On Mon, Aug 18, 2014 at 11:38 AM, Fujii Masao <fujii@postgresql.org> wrote: > Add missing index terms for replication commands in the document. > > Previously only CREATE_REPLICATION_SLOT was exposed as an index term. > That's odd and there is no reason not to add index terms for other > replication commands. Wouldn't it be worth back-patching more a lighter patch for BASE_BACKUP, START_REPLICATION and TIMELINE_HISTORY and IDENTIFY_SYSTEM? Regards, -- Michael
On Mon, Aug 18, 2014 at 11:48 AM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Mon, Aug 18, 2014 at 11:38 AM, Fujii Masao <fujii@postgresql.org> wrote: >> Add missing index terms for replication commands in the document. >> >> Previously only CREATE_REPLICATION_SLOT was exposed as an index term. >> That's odd and there is no reason not to add index terms for other >> replication commands. > Wouldn't it be worth back-patching more a lighter patch for > BASE_BACKUP, START_REPLICATION and TIMELINE_HISTORY and > IDENTIFY_SYSTEM? I don't feel inclined to do that because it's not a bug fix. I have no objection if many people want that, though... Regards, -- Fujii Masao
Re: pgsql: Add missing index terms for replication commands in the document
From
Bruce Momjian
Date:
On Mon, Aug 18, 2014 at 12:28:52PM +0900, Fujii Masao wrote: > On Mon, Aug 18, 2014 at 11:48 AM, Michael Paquier > <michael.paquier@gmail.com> wrote: > > On Mon, Aug 18, 2014 at 11:38 AM, Fujii Masao <fujii@postgresql.org> wrote: > >> Add missing index terms for replication commands in the document. > >> > >> Previously only CREATE_REPLICATION_SLOT was exposed as an index term. > >> That's odd and there is no reason not to add index terms for other > >> replication commands. > > Wouldn't it be worth back-patching more a lighter patch for > > BASE_BACKUP, START_REPLICATION and TIMELINE_HISTORY and > > IDENTIFY_SYSTEM? > > I don't feel inclined to do that because it's not a bug fix. > I have no objection if many people want that, though... Agreed. I often avoid backpatching as it requires those who translate the docs to make more adjustments for minor releases. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. +
Re: pgsql: Add missing index terms for replication commands in the document
From
Michael Paquier
Date:
On Thu, Aug 21, 2014 at 8:33 AM, Bruce Momjian <bruce@momjian.us> wrote: > On Mon, Aug 18, 2014 at 12:28:52PM +0900, Fujii Masao wrote: >> I don't feel inclined to do that because it's not a bug fix. >> I have no objection if many people want that, though... > > Agreed. I often avoid backpatching as it requires those who translate > the docs to make more adjustments for minor releases. I see, thanks! This is a valid concern. I'll be more careful in the future. Regards, -- Michael