Thread: pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.
Copy the libpq DLL to the bin directory on Mingw and Cygwin. This has long been done by the MSVC build system, and has caused confusion in the past when programs like psql have failed to start because they can't find the DLL. If it's in the same directory as it now will be they will find it. Backpatch to all live branches. Branch ------ REL8_4_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/ae3c98b9b10659e9d9c1dfb375624b0e6a299b30 Modified Files -------------- src/interfaces/libpq/Makefile | 9 +++++++++ 1 file changed, 9 insertions(+)
Andrew Dunstan <andrew@dunslane.net> writes:
> Copy the libpq DLL to the bin directory on Mingw and Cygwin.
AFAICT, this patch set is completely broken.
The buildfarm shows that every build attempt on the 8.4 branch has
failed since it went in. This is because MKDIR_P isn't defined in
that branch; you need to use $(mkinstalldirs) instead. However,
the bigger problem is the fact that non-Windows platforms are even
reaching that code; apparently, your if-logic is wrong. Testing
shows that libpq.so is getting installed into the bindir in HEAD
on my quite definitely not Windows system.
regards, tom lane
On 02/01/2014 07:14 PM, Tom Lane wrote: > Andrew Dunstan <andrew@dunslane.net> writes: >> Copy the libpq DLL to the bin directory on Mingw and Cygwin. > AFAICT, this patch set is completely broken. > > The buildfarm shows that every build attempt on the 8.4 branch has > failed since it went in. This is because MKDIR_P isn't defined in > that branch; you need to use $(mkinstalldirs) instead. However, > the bigger problem is the fact that non-Windows platforms are even > reaching that code; apparently, your if-logic is wrong. Testing > shows that libpq.so is getting installed into the bindir in HEAD > on my quite definitely not Windows system. > Argh! OK, will fix. cheers andrew