Re: pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.
Date
Msg-id 23314.1391300063@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
Andrew Dunstan <andrew@dunslane.net> writes:
> Copy the libpq DLL to the bin directory on Mingw and Cygwin.

AFAICT, this patch set is completely broken.

The buildfarm shows that every build attempt on the 8.4 branch has
failed since it went in.  This is because MKDIR_P isn't defined in
that branch; you need to use $(mkinstalldirs) instead.  However,
the bigger problem is the fact that non-Windows platforms are even
reaching that code; apparently, your if-logic is wrong.  Testing
shows that libpq.so is getting installed into the bindir in HEAD
on my quite definitely not Windows system.

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix some wide-character bugs in the text-search parser.
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Copy the libpq DLL to the bin directory on Mingw and Cygwin.