Thread: pgsql: In pg_upgrade, check there are no prepared transactions.

In pg_upgrade, check there are no prepared transactions.

Backpatch to 9.1.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/5561fe21846a3d9d0e97879fd95c79d3575886b0

Modified Files
--------------
contrib/pg_upgrade/check.c |   33 +++++++++++++++++++++++++++++++++
1 files changed, 33 insertions(+), 0 deletions(-)

On 14 June 2011 19:42, Bruce Momjian <bruce@momjian.us> wrote:
> In pg_upgrade, check there are no prepared transactions.

Out of curiosity, why would you check the new cluster for prepared transactions?

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thom Brown wrote:
> On 14 June 2011 19:42, Bruce Momjian <bruce@momjian.us> wrote:
> > In pg_upgrade, check there are no prepared transactions.
>
> Out of curiosity, why would you check the new cluster for prepared transactions?

Yes, I was debating mentioning why I did that.  First, the new cluster
should be empty, so there is a procedural issue that if it isn't, they
probably did something wrong.  Second, I am worried that replying a
prepared transaction, now that transaction ids are now different
(remember we froze _everthing_) might not work, and I don't want to try
to find out that it works now and doesn't work later, to safety says to
just disallow it.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +