Thread: pgsql: Make the Windows tcp keepalive support depend on the existance of

pgsql: Make the Windows tcp keepalive support depend on the existance of

From
mha@postgresql.org (Magnus Hagander)
Date:
Log Message:
-----------
Make the Windows tcp keepalive support depend on the existance of the
SIO_KEEPALIVE_VALS define instead of just WIN32, since MingW doesn't
support this API (yet?).

Modified Files:
--------------
    pgsql/src/backend/libpq:
        pqcomm.c (r1.211 -> r1.212)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/pqcomm.c?r1=1.211&r2=1.212)
    pgsql/src/interfaces/libpq:
        fe-connect.c (r1.397 -> r1.398)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-connect.c?r1=1.397&r2=1.398)

Re: pgsql: Make the Windows tcp keepalive support depend on the existance of

From
Andrew Dunstan
Date:

Magnus Hagander wrote:
> Log Message:
> -----------
> Make the Windows tcp keepalive support depend on the existance of the
> SIO_KEEPALIVE_VALS define instead of just WIN32, since MingW doesn't
> support this API (yet?).
>
>
>

Maybe I misunderstood. I thought you were going to include the required
defines if they were missing, rather than just disable the code in that
case.

cheers

andrew

Re: pgsql: Make the Windows tcp keepalive support depend on the existance of

From
Magnus Hagander
Date:
On Thu, Jul 8, 2010 at 18:40, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> Magnus Hagander wrote:
>>
>> Log Message:
>> -----------
>> Make the Windows tcp keepalive support depend on the existance of the
>> SIO_KEEPALIVE_VALS define instead of just WIN32, since MingW doesn't
>> support this API (yet?).
>>
>>
>>
>
> Maybe I misunderstood. I thought you were going to include the required
> defines if they were missing, rather than just disable the code in that
> case.

One of us definitely misunderstood, because this is how I read Tom's
suggestion. It'll be unsupported on mingw until they add the required
define and structure - and when they do, we'll automatically support
it.


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/