Re: pgsql: Make the Windows tcp keepalive support depend on the existance of - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: pgsql: Make the Windows tcp keepalive support depend on the existance of
Date
Msg-id AANLkTik--PhFlttqx4Z9Ks2PC9cVbtn1CRCTPzF3FJLV@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Make the Windows tcp keepalive support depend on the existance of  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
On Thu, Jul 8, 2010 at 18:40, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> Magnus Hagander wrote:
>>
>> Log Message:
>> -----------
>> Make the Windows tcp keepalive support depend on the existance of the
>> SIO_KEEPALIVE_VALS define instead of just WIN32, since MingW doesn't
>> support this API (yet?).
>>
>>
>>
>
> Maybe I misunderstood. I thought you were going to include the required
> defines if they were missing, rather than just disable the code in that
> case.

One of us definitely misunderstood, because this is how I read Tom's
suggestion. It'll be unsupported on mingw until they add the required
define and structure - and when they do, we'll automatically support
it.


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

pgsql-committers by date:

Previous
From: momjian@postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Doc change: effected -> affected, per correction from Matthew
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and