Thread: pgsql: Add missing header.
Log Message: ----------- Add missing header. Modified Files: -------------- pgsql/src/pl/plpython: plpython.c (r1.113 -> r1.114) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c?r1=1.113&r2=1.114) pgsql/src/pl/tcl: pltcl.c (r1.122 -> r1.123) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/tcl/pltcl.c?r1=1.122&r2=1.123)
alvherre@postgresql.org (Alvaro Herrera) writes: > Add missing header. I'm confused. Wouldn't the buildfarm have been complaining if this were needed? regards, tom lane
Tom Lane wrote: > alvherre@postgresql.org (Alvaro Herrera) writes: > > Add missing header. > > I'm confused. Wouldn't the buildfarm have been complaining if this > were needed? It complained that the function was not declared, but it was just a warning. See for example: http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=centaur&dt=2008-10-09%20200602&stg=make ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing-fwrapv -g -fpic -I. -I/usr/include/python2.4 -I../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include/et -c -o plpython.o plpython.c plpython.c: In function '_PG_init': plpython.c:2752: warning: implicit declaration of function 'set_text_domain' -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.