Re: pgsql: Add missing header. - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Add missing header.
Date
Msg-id 20081013220733.GD4574@alvh.no-ip.org
Whole thread Raw
In response to Re: pgsql: Add missing header.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> alvherre@postgresql.org (Alvaro Herrera) writes:
> > Add missing header.
>
> I'm confused.  Wouldn't the buildfarm have been complaining if this
> were needed?

It complained that the function was not declared, but it was just a warning.
See for example:

http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=centaur&dt=2008-10-09%20200602&stg=make

ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing-fwrapv -g -fpic -I. -I/usr/include/python2.4 -I../../../src/include -D_GNU_SOURCE
-I/usr/include/libxml2 -I/usr/include/et  -c -o plpython.o plpython.c 
plpython.c: In function '_PG_init':
plpython.c:2752: warning: implicit declaration of function 'set_text_domain'

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Implement comparison of generic records (composite types), and
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Eliminate unnecessary array[] decoration in examples of recursive