Thread: pgsql: /contrib/cube improvements: Update the calling convention for

Log Message:
-----------
/contrib/cube improvements:

Update the calling convention for all external facing functions. By
external facing, I mean all functions that are directly referenced in
cube.sql. Prior to my update, all functions used the older V0 calling
convention. They now use V1.

New Functions:

cube(float[]), which makes a zero volume cube from a float array

cube(float[], float[]), which allows the user to create a cube from
two float arrays; one for the upper right and one for the lower left
coordinate.

cube_subset(cube, int4[]), to allow you to reorder or choose a subset of
dimensions from a cube, using index values specified in the array.

Joshua Reich

Modified Files:
--------------
    pgsql/contrib/cube:
        CHANGES (r1.2 -> r1.3)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/CHANGES.diff?r1=1.2&r2=1.3)
        README.cube (r1.7 -> r1.8)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/README.cube.diff?r1=1.7&r2=1.8)
        cube.c (r1.26 -> r1.27)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/cube.c.diff?r1=1.26&r2=1.27)
        cube.sql.in (r1.17 -> r1.18)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/cube.sql.in.diff?r1=1.17&r2=1.18)
        uninstall_cube.sql (r1.2 -> r1.3)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/uninstall_cube.sql.diff?r1=1.2&r2=1.3)
    pgsql/contrib/cube/expected:
        cube.out (r1.16 -> r1.17)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/expected/cube.out.diff?r1=1.16&r2=1.17)
    pgsql/contrib/cube/sql:
        cube.sql (r1.8 -> r1.9)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/sql/cube.sql.diff?r1=1.8&r2=1.9)

momjian@postgresql.org (Bruce Momjian) writes:
> Log Message:
> -----------
> /contrib/cube improvements:

Should I point out that the buildfarm universally reports failure?

            regards, tom lane

Joshua Reich <josh@root.net> writes:
> Can you point to me where I can get a regression diff for a failed
> build.

It's all on the webpage, just scroll down ...

            regards, tom lane

Can you point to me where I can get a regression diff for a failed
build. For the install-checks that I looked at on the buildfarm, I see:

============== running regression test queries        ==============
test cube                 ... ok


Josh

Tom Lane wrote:
> momjian@postgresql.org (Bruce Momjian) writes:
>
>> Log Message:
>> -----------
>> /contrib/cube improvements:
>>
>
> Should I point out that the buildfarm universally reports failure?
>
>             regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to majordomo@postgresql.org so that your
>        message can get through to the mailing list cleanly
>

Ok. If I understand this correctly, earthdistance required cube. So,
I'll fix the test for earthdistance to work with the new cube code.

The problem is that there are new functions in cube.sql, so the output
is now different and breaks the diff (to state the obvious).

Josh Reich


Tom Lane wrote:
> Joshua Reich <josh@root.net> writes:
>
>> Can you point to me where I can get a regression diff for a failed
>> build.
>>
>
> It's all on the webpage, just scroll down ...
>
>             regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
>                http://archives.postgresql.org
>