Thread: pgsql: Add simplified sparc8 ASM for solaris_sparc.s, from Alan Stange.
pgsql: Add simplified sparc8 ASM for solaris_sparc.s, from Alan Stange.
From
momjian@postgresql.org (Bruce Momjian)
Date:
Log Message: ----------- Add simplified sparc8 ASM for solaris_sparc.s, from Alan Stange. Modified Files: -------------- pgsql/src/backend/port/tas: solaris_sparc.s (r1.7 -> r1.8) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/port/tas/solaris_sparc.s.diff?r1=1.7&r2=1.8)
momjian@postgresql.org (Bruce Momjian) writes: > Add simplified sparc8 ASM for solaris_sparc.s, from Alan Stange. Has this actually been tested at all? The reason I don't think it works is that ldstub and cas are not interchangeable; they don't even work on the same data width. Surely there need to be some #ifdefs in s_lock.h as well. regards, tom lane
Tom Lane wrote: > momjian@postgresql.org (Bruce Momjian) writes: > > Add simplified sparc8 ASM for solaris_sparc.s, from Alan Stange. > > Has this actually been tested at all? > > The reason I don't think it works is that ldstub and cas are not > interchangeable; they don't even work on the same data width. > Surely there need to be some #ifdefs in s_lock.h as well. What I did was to assign to %o1 like is done with ldstub, so I assume that will work. You are right that we had trouble with 'cas' until we changed the typedef for slock_t from unsigned char to int, so I added this patch to use 'unsigned char' for sparcv8. As far as testing, I think we are going to have to wait for someone who cares about sparcv8 because none of our current Sparc guys are testing on that. -- Bruce Momjian http://candle.pha.pa.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +