Thread: cvs commit: pgmemcache pgmemcache.c
seanc 2004/12/17 22:40:51 GMT PostgreSQL src repository Modified files: . pgmemcache.c Log: *) Explicitly inline the macro wrappers for pfree(), palloc(), pstrdup(), and the homegrown pstrdup(). *) Have the MCM_CHECK() macro now check if the global memcache memory context is NULL along with the global memcache struct. *) Quench a handful of gcc(1) warnings that can't exist, but crop up because it doesn't grok that elog(ERROR,...) longjump(3)'s out of the given function. *) Mechanically replace all mc_*(...) calls with mcm_*(ctxt, ...) to make use of the newly written multiple memory context API. This change requires that libmemcache(3) 1.1.0rc2 or newer is used. *) Rename all MC_* macros to MCM_* to aid in detection of API calls that don't make use of the multiple memory context api. There should be nothing that matches [Mm][Cc]_* anywhere in pgmemcache now. *) Conditionalize the memory initialization on the global memory context, not on the global memcache struct. In the future I'd like to be able to support multiple memcache server lists/structs in the same backend. This aids in that eventual goal. Revision Changes Path 1.2 +78 -71 pgmemcache/pgmemcache.c
This commit message On Fri, 17 Dec 2004 seanc@pgfoundry.org wrote: > seanc 2004/12/17 22:40:51 GMT > > PostgreSQL src repository > > Modified files: > . pgmemcache.c > Log: > *) Explicitly inline the macro wrappers for pfree(), palloc(), pstrdup(), > and the homegrown pstrdup(). > > *) Have the MCM_CHECK() macro now check if the global memcache memory > context is NULL along with the global memcache struct. > > *) Quench a handful of gcc(1) warnings that can't exist, but crop up > because it doesn't grok that elog(ERROR,...) longjump(3)'s out of the > given function. > > *) Mechanically replace all mc_*(...) calls with mcm_*(ctxt, ...) to make > use of the newly written multiple memory context API. This change > requires that libmemcache(3) 1.1.0rc2 or newer is used. > > *) Rename all MC_* macros to MCM_* to aid in detection of API calls that > don't make use of the multiple memory context api. There should be > nothing that matches [Mm][Cc]_* anywhere in pgmemcache now. > > *) Conditionalize the memory initialization on the global memory context, > not on the global memcache struct. In the future I'd like to be able to > support multiple memcache server lists/structs in the same backend. > This aids in that eventual goal. > > Revision Changes Path > 1.2 +78 -71 pgmemcache/pgmemcache.c > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org >
What I meant to write was, this commit message subject header is not using the pgfoundry format that was supposed to alleviate all concerns about flooding this list with messages that I am not interested in. Kris Jurka
> What I meant to write was, this commit message subject header is not > using > the pgfoundry format that was supposed to alleviate all concerns about > flooding this list with messages that I am not interested in. Sorry about hijacking your message headers. I just committed a fix for that. I was going insane having to look at the old commit message format and its lack of detail regarding the commit. All is well now. -sc -- Sean Chittenden