Thread: pgsql-server/src/backend/utils/adt numeric.c

CVSROOT:    /cvsroot
Module name:    pgsql-server
Changes by:    tgl@svr1.postgresql.org    03/07/03 16:41:47

Modified files:
    src/backend/utils/adt: numeric.c

Log message:
    Fix bug I introduced in recent rewrite of NUMERIC code: numeric to
    integer conversions gave the wrong answer for values with stripped
    trailing zeroes, such as 10000000.

On Thu, Jul 03, 2003 at 04:41:48PM -0300, Tom Lane wrote:

> Log message:
>     Fix bug I introduced in recent rewrite of NUMERIC code: numeric to
>     integer conversions gave the wrong answer for values with stripped
>     trailing zeroes, such as 10000000.

No regression test?

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Porque francamente, si para saber manejarse a uno mismo hubiera que
rendir examen... ¿Quién es el machito que tendría carnet?"  (Mafalda)

Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
>> Fix bug I introduced in recent rewrite of NUMERIC code: numeric to
>> integer conversions gave the wrong answer for values with stripped
>> trailing zeroes, such as 10000000.

> No regression test?

Don't see the point --- it's a one-off fix.  (Wrong loop termination
condition in one place.)  I put in regression tests for things that
I think might break again in future, or if I can see a way to test for
a whole class of errors rather than one single routine.

            regards, tom lane