Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql-server/src/backend/utils/adt numeric.c - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server/src/backend/utils/adt numeric.c
Date
Msg-id 2642.1057266810@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql-server/src/backend/utils/adt numeric.c  (Alvaro Herrera <alvherre@dcc.uchile.cl>)
List pgsql-committers
Tree view 
Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
>> Fix bug I introduced in recent rewrite of NUMERIC code: numeric to
>> integer conversions gave the wrong answer for values with stripped
>> trailing zeroes, such as 10000000.

> No regression test?

Don't see the point --- it's a one-off fix.  (Wrong loop termination
condition in one place.)  I put in regression tests for things that
I think might break again in future, or if I can see a way to test for
a whole class of errors rather than one single routine.

            regards, tom lane

pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql-server/src/backend/utils/adt numeric.c
Next
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql-server/src backend/catalog/aclchk.c back ...