Postgres Pro
Downloads
Home   >   mailing lists

Thread: cannot to set track_activity_query_size in kB

cannot to set track_activity_query_size in kB

From
Pavel Stehule
Date:
Hello

I got a message

LOG:  invalid value for parameter "track_activity_query_size": "64kB"
FATAL:  configuration file "/usr/local/pgsql/data/postgresql.conf" contains
errors

for

track_activity_query_size = 64kB

Regards

Pavel Stehule

Re: cannot to set track_activity_query_size in kB

From
Bruce Momjian
Date:
On Wed, Apr  9, 2014 at 11:25:23AM +0200, Pavel Stehule wrote:
> Hello
>
> I got a message
>
> LOG:  invalid value for parameter "track_activity_query_size": "64kB"
> FATAL:  configuration file "/usr/local/pgsql/data/postgresql.conf" contains
> errors
>
> for
>
> track_activity_query_size = 64kB

I looked into this and the cause is that we don't have any _bytes_ GUC
unit setting, we only have 3:

    #define GUC_UNIT_KB             0x0400  /* value is in kilobytes */
    #define GUC_UNIT_BLOCKS         0x0800  /* value is in blocks */
    #define GUC_UNIT_XBLOCKS        0x0C00  /* value is in xlog blocks */
    #define GUC_UNIT_MEMORY         0x0C00  /* mask for KB, BLOCKS, XBLOCKS */

Should I add a _bytes_ setting so this works, or just add a C comment
that it doesn't?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

Re: cannot to set track_activity_query_size in kB

From
Tom Lane
Date:
Bruce Momjian <bruce@momjian.us> writes:
> Should I add a _bytes_ setting so this works,

No.  Not without more than one example, and preferably a more compelling
example than this.  That value seems insanely high for that parameter.

            regards, tom lane

Re: cannot to set track_activity_query_size in kB

From
Pavel Stehule
Date:
2014-04-09 12:54 GMT+02:00 Bruce Momjian <bruce@momjian.us>:

> On Wed, Apr  9, 2014 at 11:25:23AM +0200, Pavel Stehule wrote:
> > Hello
> >
> > I got a message
> >
> > LOG:  invalid value for parameter "track_activity_query_size": "64kB"
> > FATAL:  configuration file "/usr/local/pgsql/data/postgresql.conf"
> contains
> > errors
> >
> > for
> >
> > track_activity_query_size = 64kB
>
> I looked into this and the cause is that we don't have any _bytes_ GUC
> unit setting, we only have 3:
>
>         #define GUC_UNIT_KB             0x0400  /* value is in kilobytes */
>         #define GUC_UNIT_BLOCKS         0x0800  /* value is in blocks */
>         #define GUC_UNIT_XBLOCKS        0x0C00  /* value is in xlog blocks
> */
>         #define GUC_UNIT_MEMORY         0x0C00  /* mask for KB, BLOCKS,
> XBLOCKS */
>
> Should I add a _bytes_ setting so this works, or just add a C comment
> that it doesn't?
>

Change this value is not usual, so it can be only in KB - but, can be nice
it be commented there

Regards

Pavel


>
> --
>   Bruce Momjian  <bruce@momjian.us>        http://momjian.us
>   EnterpriseDB                             http://enterprisedb.com
>
>   + Everyone has their own god. +
>