Re: cannot to set track_activity_query_size in kB - Mailing list pgsql-bugs

From Bruce Momjian
Subject Re: cannot to set track_activity_query_size in kB
Date
Msg-id 20140409105421.GN8685@momjian.us
Whole thread Raw
In response to cannot to set track_activity_query_size in kB  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: cannot to set track_activity_query_size in kB  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: cannot to set track_activity_query_size in kB  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-bugs
On Wed, Apr  9, 2014 at 11:25:23AM +0200, Pavel Stehule wrote:
> Hello
>
> I got a message
>
> LOG:  invalid value for parameter "track_activity_query_size": "64kB"
> FATAL:  configuration file "/usr/local/pgsql/data/postgresql.conf" contains
> errors
>
> for
>
> track_activity_query_size = 64kB

I looked into this and the cause is that we don't have any _bytes_ GUC
unit setting, we only have 3:

    #define GUC_UNIT_KB             0x0400  /* value is in kilobytes */
    #define GUC_UNIT_BLOCKS         0x0800  /* value is in blocks */
    #define GUC_UNIT_XBLOCKS        0x0C00  /* value is in xlog blocks */
    #define GUC_UNIT_MEMORY         0x0C00  /* mask for KB, BLOCKS, XBLOCKS */

Should I add a _bytes_ setting so this works, or just add a C comment
that it doesn't?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

pgsql-bugs by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: BUG #9897: Wrong Julian Date through ODBC
Next
From: Michael Paquier
Date:
Subject: Re: BUG #9897: Wrong Julian Date through ODBC